Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#28568:GraphQL query returns admin option value label… #28645

Closed
wants to merge 1 commit into from

Conversation

gallyamov
Copy link
Contributor

@gallyamov gallyamov commented Jun 9, 2020

Description (*)

This is for #28568 and #28572

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Fixes GraphQL query returns admin option value label within aggregations #28568: Query returns admin option value label within aggregations
  2. Fixes [GraphQl] Custom attribute aggregations should return store specific option values #28572: Custom attribute aggregations should return store specific option values

Manual testing scenarios (*)

Check fixed issue for testing steps and expected results.

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @gallyamov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @gallyamov

Unfortunately, we cannot accept Pull Requests from branches created in magento2 repository.
Please use your own fork as a base for this Pull Request.

Thank you.

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @gallyamov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gallyamov
Copy link
Contributor Author

@magento run all tests

@gallyamov gallyamov deleted the 28568_admin_option_labels branch June 9, 2020 16:25
@cpartica cpartica added the PAP Partners acceleration program label Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants