Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused construct parameters #28653

Merged
merged 4 commits into from
Sep 7, 2020
Merged

Removed unused construct parameters #28653

merged 4 commits into from
Sep 7, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Jun 9, 2020 •
edited by m2-assistant bot
Loading

Description (*)

This PR removes some unused parameters in construct of the class

Resolved issues:

  1. resolves [Issue] Removed unused construct parameters #29531: Removed unused construct parameters

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 9, 2020
@magento-engcom-team magento-engcom-team added Component: AdvancedPricingImportExport Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 9, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Jun 9, 2020

@magento run all tests

lbajsarowicz
lbajsarowicz suggested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix static checks by removing

Class AdvancedPricing
 *
 *

Also please remove empty lines between const declarations (you can actually keep them in groups), and when it's possible, add the visibility to the const elements.

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Jun 10, 2020
@ghost ghost assigned lbajsarowicz Jun 10, 2020
@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203
Copy link
Contributor Author

Hi @lbajsarowicz
I have fixed failed static test also removed empty lines between const declarations
Thanks

@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie engcom-Charlie moved this from Changes Requested to Review in Progress in Pull Requests Dashboard Jul 21, 2020
@sidolov
Copy link
Contributor

sidolov commented Aug 13, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 13, 2020
Closed
@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Aug 13, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 2, 2020

Hi @lbajsarowicz
Could I kindly ask you to review this one .
Thanks!

lbajsarowicz
lbajsarowicz approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Greenlight from my side.

@ghost ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Sep 2, 2020
@lbajsarowicz lbajsarowicz added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 2, 2020
@engcom-Delta engcom-Delta self-assigned this Sep 7, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 7, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked that Advanced Pricing import works as before

@engcom-Delta
Copy link
Contributor

Note: All automation tests are passed

@engcom-Delta engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 7, 2020
@engcom-Delta engcom-Delta moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Sep 7, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 7, 2020
@gabrieldagama
ENGCOM-8117: Removed unused construct parameters #28653
b6e8ec7
@magento-engcom-team magento-engcom-team merged commit 20166c1 into magento:2.4-develop Sep 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 7, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: AdvancedPricingImportExport Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Removed unused construct parameters
5 participants
@Usik2203 @sidolov @engcom-Delta @lbajsarowicz @magento-engcom-team