Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move localstorage polyfill to frontend #28749

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Move localstorage polyfill to frontend #28749

merged 2 commits into from
Jul 16, 2020

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Jun 17, 2020 •
edited by m2-assistant bot
Loading

Description (*)

This PR moves localstorage polyfill from base to frontend area, based on the following feedback #27619 (comment)

/CC @krzksz @omiroshnichenko

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Storage polyfill is only loaded and applied when either localStorage or sessionStorage are not available.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Move localstorage polyfill to frontend #28900: Move localstorage polyfill to frontend

@m2-assistant
Copy link

m2-assistant bot commented Jun 17, 2020

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 17, 2020
@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev mentioned this pull request Jun 17, 2020
Merged
5 tasks
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jun 17, 2020
@ghost ghost assigned krzksz Jun 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-7698 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@krzksz krzksz added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 17, 2020
@ihor-sviziev ihor-sviziev added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Jun 17, 2020
@ihor-sviziev
Copy link
Contributor Author

@krzksz thank you!
Added label Severity: S2 to be the same as original PR.

@ghost ghost assigned ptylek Jun 21, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-7698 has been created to process this Pull Request

@lenaorobei lenaorobei added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. and removed Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jun 24, 2020
@engcom-Delta engcom-Delta self-assigned this Jun 25, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jun 25, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked:

  • polyfill.js is not loaded when localStorage or sessionStorage are available

#28749PR

  • polyfill.js is loaded when cookies are blocked

#28749PRNoCookie

  • polyfill.js is not loaded in admin panel on different pages
    image

@engcom-Delta engcom-Delta moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jun 25, 2020
@engcom-Charlie engcom-Charlie self-assigned this Jun 25, 2020
@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 26, 2020
@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jun 26, 2020
Closed
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 26, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jun 30, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jul 6, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 16, 2020
@lenaorobei
ENGCOM-7698: Move localstorage polyfill to frontend #28749
b610464
@magento-engcom-team magento-engcom-team merged commit 22ef6a1 into 2.4-develop Jul 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2020

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jul 16, 2020
@ihor-sviziev ihor-sviziev deleted the move-localstorage-polyfill-to-frontend branch July 28, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzksz krzksz krzksz approved these changes

@ptylek ptylek ptylek approved these changes

Assignees

@krzksz krzksz

@ptylek ptylek

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Theme Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] Move localstorage polyfill to frontend
8 participants
@ihor-sviziev @magento-engcom-team @engcom-Delta @krzksz @ptylek @slavvka @lenaorobei @engcom-Charlie