Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce observers to track deleted entities #28798

Merged
merged 3 commits into from
Jun 24, 2020
Merged

Introduce observers to track deleted entities #28798

merged 3 commits into from
Jun 24, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Jun 18, 2020

Description (*)

Fixed Issues (if relevant)

  1. Fixes The "Used in" still displays that the image is used in a Product after the Product has been deleted adobe-stock-integration#1474: The "Used in" still displays that the image is used in a Product after the Product has been deleted
  2. ...

Manual testing scenarios (*)

  1. Create a Product and add an image from Media Gallery
  2. Go to Content - Media Gallery and View the Details of the image that was previously added to the Product
  3. Verify that the Details display that the image is Used In 1 Product
  4. Go to Catalog - Products and Delete the previously created Product
  5. Go to Go to Content - Media Gallery and View the Details of the image that was previously Used

The image is not Used in a product so it should not be displayed in Details

@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 18, 2020

@magento run all tests

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jun 18, 2020
@ghost ghost assigned sivaschenko Jun 18, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-7709 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sivaschenko
Copy link
Member

The pull request contains observers for operations that are covered by the tests, the services that are used by observers are covered by the tests as well.

There is no functionality in magento2 currently that can be used to cover the observers functionality currently, these cases should be covered by MFTF tests in Adobe Stock Integration project.

@sivaschenko sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 18, 2020
@chalov-anton chalov-anton moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jun 18, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jun 18, 2020

@magento run all tests

@chalov-anton chalov-anton self-assigned this Jun 18, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Test scenario on cucumber studio https://studio.cucumber.io/projects/131313/test-plan/folders/1054245/scenarios/3962930

@lenaorobei lenaorobei added this to the 2.4.1 milestone Jun 22, 2020
@lenaorobei lenaorobei added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jun 22, 2020
@sivaschenko sivaschenko moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Jun 23, 2020
@bradleybrecher
Copy link
Contributor

@magento give me 2.3.2-p2 instance

@magento-engcom-team
Copy link
Contributor

Hi @bradleybrecher. Thank you for your request. I'm working on Magento 2.3.2-p2 instance for you

@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaContentCatalog Component: MediaContentCms Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

The "Used in" still displays that the image is used in a Product after the Product has been deleted
7 participants