Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "parent" products sku inconsistency with product_id #28847

Open
wants to merge 2 commits into
base: 2.5-develop
Choose a base branch
from
Open

fix "parent" products sku inconsistency with product_id #28847

wants to merge 2 commits into from

Conversation

engcom-Charlie
Copy link
Contributor

Description (*)

Fixed and covered by test.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes REST API order info -> "parent" products sku inconsistency with product_id  #21231

Manual testing scenarios (*)

See #21231

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 23, 2020

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 23, 2020
@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 14, 2020
@ihor-sviziev
Copy link
Contributor

@engcom-Charlie I think it should be fixed together with #25461, seems to me quite related.

@gabrieldagama gabrieldagama added this to the 2.5 milestone Sep 22, 2020
@sidolov sidolov moved this from Pending Review to On Hold in Pull Requests Dashboard Oct 1, 2020
@orlangur orlangur self-assigned this Dec 20, 2020
@orlangur
Copy link
Contributor

@magento run all tests

@m2-community-project m2-community-project bot moved this from On Hold to Review in Progress in Pull Requests Dashboard Dec 20, 2020
@orlangur
Copy link
Contributor

it should be fixed together with #25461, seems to me quite related.

not really as of #25461 (reference)

@ihor-sviziev
Copy link
Contributor

@engcom-Charlie could you re-target this PR to 2.5-develop branch?

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Jan 13, 2021
@engcom-Charlie engcom-Charlie changed the base branch from 2.4-develop to 2.5-develop January 13, 2021 10:12
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Pull Requests Dashboard Jan 13, 2021
@m2-community-project m2-community-project bot added this to Review in Progress in 2.5 Milestone PRs Dashboard Jan 22, 2021
@m2-community-project m2-community-project bot removed this from Review in Progress in Pull Requests Dashboard Jan 22, 2021
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Requests Dashboard Mar 9, 2022
@m2-community-project m2-community-project bot removed this from Review in Progress in 2.5 Milestone PRs Dashboard Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@orlangur orlangur

Labels
Component: Quote Priority: P3 May be fixed according to the position in the backlog. Progress: review Release Line: 2.5 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Review in Progress
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

REST API order info -> "parent" products sku inconsistency with product_id
6 participants
@engcom-Charlie @ihor-sviziev @orlangur @gabrieldagama @sidolov @magento-engcom-team