Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Remove redundant cron run #28852

Merged
merged 3 commits into from
Jul 11, 2020
Merged

[MFTF] Remove redundant cron run #28852

merged 3 commits into from
Jul 11, 2020

Conversation

Usik2203
Copy link
Contributor

Description (*)

This PR removes twice cron run

@m2-assistant
Copy link

m2-assistant bot commented Jun 23, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 23, 2020
@magento-engcom-team magento-engcom-team added Component: Catalog Component: CatalogRule Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 23, 2020
@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests B2B

@rogyar rogyar self-assigned this Jun 24, 2020
@rogyar rogyar added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Jun 24, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jun 24, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7735 has been created to process this Pull Request

ihor-sviziev
ihor-sviziev reviewed Jun 24, 2020
View reviewed changes
...de/Magento/Catalog/Test/Mftf/Test/AdminCreateInactiveFlatCategoryAndUpdateAsInactiveTest.xml Outdated
<magentoCLI command="cron:run" arguments="--group=index" stepKey="runCron1"/>
<magentoCLI command="cron:run" arguments="--group=index" stepKey="runCron2"/>
<!-- Run cron -->
<magentoCLI command="cron:run" arguments="--group=index" stepKey="runCron"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use https://devdocs.magento.com/mftf/docs/test/actions.html#magentocron instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihor-sviziev we can use it
Thank you for advice.

@ghost ghost assigned ihor-sviziev Jun 24, 2020
@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE

@ihor-sviziev ihor-sviziev removed their assignment Jun 25, 2020
@Usik2203
Copy link
Contributor Author

@magento run all tests

@engcom-Delta engcom-Delta self-assigned this Jul 6, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 6, 2020
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Delta engcom-Delta moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 6, 2020
@engcom-Charlie engcom-Charlie self-assigned this Jul 6, 2020
@engcom-Charlie engcom-Charlie added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 7, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jul 7, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jul 7, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 7, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 11, 2020
@slavvka
ENGCOM-7735: [MFTF] Remove redundant cron run #28852
2766c10
@magento-engcom-team magento-engcom-team merged commit 0e3e26f into magento:2.4-develop Jul 11, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 11, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev left review comments

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Component: Catalog Component: CatalogRule Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Usik2203 @magento-engcom-team @engcom-Delta @ihor-sviziev @rogyar @slavvka @engcom-Charlie