Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added table install to Magento Test Framework sequence builder #2887

Closed
wants to merge 2 commits into from
Closed

Added table install to Magento Test Framework sequence builder #2887

wants to merge 2 commits into from

Conversation

@ldusan84
Copy link
Contributor

@ldusan84 ldusan84 commented Jan 5, 2016

Currently the Test Framework's sequence builder class doesn't install the sequence tables and the regular one does.

I think that these tables should be created so that orders can be made on different stores in integration tests.

@daim2k5
Copy link
Contributor

@daim2k5 daim2k5 commented Jan 9, 2016

Thank you for the PR! We are currently waiting for the travis builds to work again, which should happen in a few days. Once that is running and the tests are green we can continue to process your contribution.

@mazhalai
Copy link
Contributor

@mazhalai mazhalai commented Jan 12, 2016

@ldusan84 Please sync with develop and rerun builds.

…InstallInStoreBuilder
@ldusan84
Copy link
Contributor Author

@ldusan84 ldusan84 commented Jan 12, 2016

@mazhalai done.

@katmoon katmoon added the PS label Feb 12, 2016
@okorshenko okorshenko added CS and removed PS labels Feb 17, 2016
@okorshenko okorshenko assigned okorshenko and unassigned okorshenko Mar 7, 2016
@vzaporozhets vzaporozhets self-assigned this Mar 7, 2016
@NadiyaS NadiyaS added PS and removed CS labels May 10, 2016
@NadiyaS NadiyaS assigned vrann and unassigned NadiyaS May 10, 2016
@vrann vrann removed their assignment May 10, 2016
@okorshenko
Copy link
Contributor

@okorshenko okorshenko commented May 12, 2016

Internal ticket: MAGETWO-52761

@okorshenko
Copy link
Contributor

@okorshenko okorshenko commented Jun 9, 2016

@ldusan84 thank you for your contribution. Could you please let me know what particular tables are missed? I tested the issue on my local with latest code from develop branch. It works as expected. Could you please provide steps to reproduce? Thank you

@okorshenko okorshenko closed this Jul 11, 2016
magento-engcom-team pushed a commit that referenced this pull request Jul 23, 2018
[TSG] Upporting for 2.3 (pr29) (2.3.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants