Added table install to Magento Test Framework sequence builder - #2887
Closed
ldusan84 wants to merge 2 commits into
Closed
Added table install to Magento Test Framework sequence builder#2887ldusan84 wants to merge 2 commits into
ldusan84 wants to merge 2 commits into
Conversation
Contributor
|
Thank you for the PR! We are currently waiting for the travis builds to work again, which should happen in a few days. Once that is running and the tests are green we can continue to process your contribution. |
Contributor
|
@ldusan84 Please sync with develop and rerun builds. |
…InstallInStoreBuilder
Contributor
Author
|
@mazhalai done. |
Contributor
|
Internal ticket: MAGETWO-52761 |
okorshenko
added
the
Issue: Ready for Work
Contributor
|
@ldusan84 thank you for your contribution. Could you please let me know what particular tables are missed? I tested the issue on my local with latest code from develop branch. It works as expected. Could you please provide steps to reproduce? Thank you |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 23, 2018
[TSG] Upporting for 2.3 (pr29) (2.3.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Test Framework's sequence builder class doesn't install the sequence tables and the regular one does.
I think that these tables should be created so that orders can be made on different stores in integration tests.