Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: Newsletter Guest Subscription With Disallowed Option Test #28872

Merged
merged 3 commits into from Jul 11, 2020
Merged

MFTF: Newsletter Guest Subscription With Disallowed Option Test #28872

merged 3 commits into from Jul 11, 2020

Conversation

DmitryTsymbal
Copy link
Contributor

@DmitryTsymbal DmitryTsymbal commented Jun 24, 2020 •
edited by m2-assistant bot

This PR contains MFTF test for guest newsletter subscription with disallowed option in configs
Deprecated VerifyRegistredLinkDisplayedForGuestSubscriptionNoTest due to inconsistency with the best practices
Deprecated StorefrontCreateNewSubscriberActionGroup due to inconsistency with the best practices

Steps to reproduce:
1 - Disallow guest subscription in configs
2 - Subscribe as guest on storefront
3 - Perform assertions

Resolved issues:

  1. resolves [Issue] MFTF: Newsletter Guest Subscription With Disallowed Option Test #29039: MFTF: Newsletter Guest Subscription With Disallowed Option Test

@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2020

Hi @DmitryTsymbal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 24, 2020
@magento-engcom-team magento-engcom-team added Component: Newsletter Component: Ui Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 24, 2020
@dmytro-ch dmytro-ch self-assigned this Jun 24, 2020
@VladimirZaets VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 24, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jun 24, 2020
@ghost ghost assigned VladimirZaets Jun 24, 2020
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-7739 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage labels Jun 25, 2020
@dmytro-ch
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7739 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Jul 7, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 7, 2020
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Delta engcom-Delta moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 7, 2020
@engcom-Kilo engcom-Kilo self-assigned this Jul 7, 2020
@engcom-Kilo engcom-Kilo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 7, 2020
@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 8, 2020
Closed
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 8, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Kilo engcom-Kilo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jul 9, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 11, 2020
@slavvka
ENGCOM-7739: MFTF: Newsletter Guest Subscription With Disallowed Opti…
b114b9b 
…on Test #28872
@magento-engcom-team magento-engcom-team merged commit 9d89a8f into magento:2.4-develop Jul 11, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 11, 2020

Hi @DmitryTsymbal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@VladimirZaets VladimirZaets

@dmytro-ch dmytro-ch

@engcom-Delta engcom-Delta

@engcom-Kilo engcom-Kilo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Newsletter Component: Ui Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] MFTF: Newsletter Guest Subscription With Disallowed Option Test
6 participants
@DmitryTsymbal @magento-engcom-team @dmytro-ch @engcom-Delta @engcom-Kilo @VladimirZaets