Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README > Removing extra space #28891

Merged
merged 2 commits into from
Jul 21, 2020
Merged

README > Removing extra space #28891

merged 2 commits into from
Jul 21, 2020

Conversation

rafaelstz
Copy link
Member

@rafaelstz rafaelstz commented Jun 25, 2020 •
edited by m2-assistant bot
Loading

Description (*)

I removed the extra space between the new logo and the badges, and I changed the logo alt from Magento to Magento Commerce as it's represented in the new logo.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] README > Removing extra space #29056: README > Removing extra space

@rafaelstz
README > Removing extra space
b5b0648 
I removed the extra space between the new logo and the badges, and I changed the logo alt from Magento to Magento Commerce as it's represented in the new logo.
@m2-assistant
Copy link

m2-assistant bot commented Jun 25, 2020

Hi @rafaelstz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 25, 2020
@davidverholen
Copy link
Member

@magento run all tests

@davidverholen davidverholen self-assigned this Jun 28, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jun 28, 2020
@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, thank you for the review.
ENGCOM-7753 has been created to process this Pull Request
✳️ @davidverholen, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@davidverholen davidverholen added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 28, 2020
@engcom-Alfa engcom-Alfa self-requested a review July 7, 2020 11:54
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 7, 2020
@engcom-Alfa engcom-Alfa self-assigned this Jul 7, 2020
@engcom-Alfa engcom-Alfa removed their request for review July 7, 2020 11:55
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Jul 7, 2020 •
edited
Loading

✔️ QA Passed

Before: ✖️ the extra space between the new logo and the badges

Screenshot from 2020-07-09 14-32-01

After: ✔️ no extra space between the new logo and the badges

Screenshot from 2020-07-09 14-35-22

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 7, 2020
@engcom-Charlie engcom-Charlie self-assigned this Jul 7, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 9, 2020
@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 9, 2020
Closed
4 tasks
@ghost ghost added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Jul 20, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 20, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jul 20, 2020
@ghost ghost added Progress: accept Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. and removed Progress: extended testing labels Jul 20, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 21, 2020
@slavvka
ENGCOM-7753: README > Removing extra space #28891
fe04785
@magento-engcom-team magento-engcom-team merged commit e76f43b into magento:2.4-develop Jul 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 21, 2020

Hi @rafaelstz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidverholen davidverholen davidverholen approved these changes

Assignees

@davidverholen davidverholen

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Le Site partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] README > Removing extra space
5 participants
@rafaelstz @davidverholen @magento-engcom-team @engcom-Alfa @engcom-Charlie