Deploy all used locales

[AntonEvers]

Description (*)

bin/magento setup:static-content:deploy --language=all currently only
deploys en_US, instead of the requested "all". This pull request aims to deploy all used languages for the frontend and all configured languages by admin users, when no language parameter is given. en_US is always additionally deployed by default.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Configure multiple store views with different locales.
2. Configure a locale other than en_US for your admin user.
3. run bin/magento setup:static-content:deploy --language=all and verify that all configured languages, plus en_US are deployed.
4. run bin/magento setup:static-content:deploy --language=all --exclude-language=en_US and verify that en_US is skipped.
5. run bin/magento setup:static-content:deploy en_US and verify that only en_US is deployed
6. run bin/magento setup:static-content:deploy --language=en_US and verify that only en_US is deployed
7. run bin/magento setup:static-content:deploy -l en_US and verify that only en_US is deployed
8. run bin/magento setup:static-content:deploy --language=en_US en_UK and verify that only en_UK is deployed as the languages argument precedes over the language option

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Deploy all used locales #29218: Deploy all used locales

[m2-assistant]

Hi @AntonEvers. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[AntonEvers]

@magento run all tests

[AntonEvers]

@magento run Unit Tests

[AntonEvers]

@magento run all tests

[VladimirZaets]

Hi @AntonEvers. Thanks for collaboration. This PR was reviewed on Community Contribution Triage meeting. The recording of the meeting you can look by the link

[ihor-sviziev]

@AntonEvers thank you so much for your contribution!
This is really important improvement!

[AntonEvers]

@ihor-sviziev please let me know if this needs some cleaning up / relocation of logic. I can imagine that the coupling of objects is getting larger than desirable at the moment.

[AntonEvers]

@magento run all tests

[AntonEvers]

@ihor-sviziev please let me know if this needs some cleaning up / relocation of logic. I can imagine that the coupling of objects is getting larger than desirable at the moment.

I went ahead and cleaned up a little. Please let me know if you see any issues with this.

[ihor-sviziev]

Good job! Thank you so much for this improvement!

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7853 has been created to process this Pull Request

[engcom-Alfa]

@magento create issue

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Configure multiple store views with different locales ( in my case en_US, de_DE and fr_FR);
2. Configure a locale other than en_US for your admin user.
3. Run in console: bin/magento setup:static-content:deploy --language=all;

Before: ✖️ only en_US are deployed;

After: ✔️ All configured languages are deployed

4. Run in console:bin/magento setup:static-content:deploy --language=all --exclude-language=en_US

After: ✔️ All configured languages except English are deployed

5. Run in console: bin/magento setup:static-content:deploy en_US

After: ✔️ Only en_US is deployed

6. Run in console: bin/magento setup:static-content:deploy -l en_US

After: ✔️ Only en_US is deployed

7. Run in console: bin/magento setup:static-content:deploy --language=en_US de_DE

After: ✔️ Only de_DE is deployed as the languages argument precedes over the language option

[m2-assistant]

Hi @AntonEvers, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.