improve and make more strict autoload.php

[rvitaliy]

Description (*)

two improvements:

1. use is_readable instead of file_exists. if we use require or include on a existing file that is not readable php generate errors. So we need to chech if file_exists and is_readable (is_readable do both things)
2. provide an anonymous function to determinate $vendorAutoload, it's allow us to have a more readable code with early return.

Related Pull Requests

none

Fixed Issues (if relevant)

none

Manual testing scenarios (*)

not necessary, if CI passes this code is good, it's only technical improvement.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] improve and make more strict autoload.php #29527: improve and make more strict autoload.php

[m2-assistant]

Hi @rvitaliy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[rvitaliy]

@magento run all tests

[rogyar]

@magento run Functional Tests B2B

[rogyar]

@magento run Functional Tests B2B

[rogyar]

Hi @rvitaliy. Thank you for your collaboration. Could I kindly ask you to provide a comment for these two declarations of $vendorAutoload with highlighting what is a particular block for? At first glance, these blocks of code look very similar (almost the same) and it's hard to guess why we need such an approach. I see that in first case we have the trailing slash, but let's make developers life a little bit easier and highlight this case in the comments. Thank you!

[rvitaliy]

@rogyar
sorry, but i can't do it.
personally i don't undestand why we need the second check without BP prefix.
i'm refactor the old code without change to the logics, make it more strict and readable.
IMHO: we can remove the second block of check, app/{$vendor} is not a valid path for vendor.

[rogyar]

Good point. I see that this functionality has been recently added. So I assume it was done for a purpose.

2054fab

Unfortunately, there's no additional information about this change. Well then, let's leave it as it is. Maybe it's required for some particular circumstances (like CI system or so).

[hostep]

@rogyar, that commit is from #18849, so there is your missing information 🙂

[rvitaliy]

so the second check is need to autoload vendors from the global path

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7830 has been created to process this Pull Request

[engcom-Charlie]

QA Not applicable

[sidolov]

@magento create issue

[m2-assistant]

Hi @rvitaliy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.