Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#28270 Showed tier price for pre selected swatch via cart edit #29137

Merged
merged 8 commits into from
Jul 29, 2020
Merged

#28270 Showed tier price for pre selected swatch via cart edit #29137

merged 8 commits into from
Jul 29, 2020

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented Jul 15, 2020 •
edited by engcom-Kilo
Loading

Description (*)

This PR helps to assign tierPriceTemplate value before swatch.initialized trigger.

Fixed Issues (if relevant)

  1. Fixes Configurable product with swatches, doesn't show tier pricing when clicking edit in cart OR when active swatch set with url hash #28270

Manual testing scenarios (*)

please check #28270

Related Pull Requests

MFTF changes for B2B version:

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 15, 2020

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jul 15, 2020
@srsathish92
Copy link
Contributor Author

@magento run all tests

krzksz
krzksz suggested changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@krzksz krzksz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for your contribution! Please fix the static tests, they seem to be not related to your changes but since you are touching the file, you have to fix it.

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Jul 15, 2020
@ghost ghost assigned krzksz Jul 15, 2020
@srsathish92 srsathish92 force-pushed the bug/28270-config-prod-via-edit-cart-with-tier-price branch from 0775651 to 2765164 Compare July 15, 2020 16:58
@srsathish92
Copy link
Contributor Author

@magento run all tests

@srsathish92
Copy link
Contributor Author

@krzksz I have fixed static test, can please review now?

@srsathish92 srsathish92 requested a review from krzksz July 16, 2020 04:47
krzksz
krzksz approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@krzksz krzksz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! Since this doesn't change any existing logic and all functional tests are passing then I would say we don't require any additional tests.

@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Jul 16, 2020
@krzksz krzksz added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 16, 2020
@krzksz
Copy link
Contributor

krzksz commented Jul 16, 2020

On the other hand, @srsathish92 do you think you would be able to write an E2E test that goes through reproduction steps outlined in #28270?

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-7845 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jul 16, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 16, 2020
@engcom-Kilo engcom-Kilo self-assigned this Jul 16, 2020
@engcom-Kilo
Copy link
Contributor

Working with MFTF test.

@engcom-Kilo engcom-Kilo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 20, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 20, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 21, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Kilo engcom-Kilo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jul 23, 2020
@slavvka slavvka mentioned this pull request Jul 29, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jul 29, 2020
@slavvka
ENGCOM-7845: #28270 Showed tier price for pre selected swatch via car…
96197a0 
…t edit #29137
@magento-engcom-team magento-engcom-team merged commit 4b3a517 into magento:2.4-develop Jul 29, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 29, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jul 29, 2020
@engcom-Alfa engcom-Alfa mentioned this pull request Oct 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzksz krzksz krzksz approved these changes

Assignees

@krzksz krzksz

@engcom-Alfa engcom-Alfa

@engcom-Kilo engcom-Kilo

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: ConfigurableProduct Component: Swatches Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
5 participants
@srsathish92 @krzksz @magento-engcom-team @engcom-Alfa @engcom-Kilo