Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/partners-magento2b2b#137: Add Company to Customers Now Online… #29170

Merged

Conversation

rsaint20
Copy link
Contributor

@rsaint20 rsaint20 commented Jul 16, 2020

… grid - Added MFTF action group to CE > UI Admin grid

Description (*)

Added MFTF Actiongroup in CE in Ui module

  • AdminAddColumnToAdminGridActionGroup
  • AdminOpenColumnActionDropDownForAdminGridActionGroup

Related Pull Requests

https://github.com/magento/partners-magento2b2b/pull/146

Fixed Issues (if relevant)

  1. Fixes magento/partners-magento2b2b#137

Manual testing scenarios (*)

  1. Navigate Admin -> Customers -> Now Online
  2. Check if Company column is not displayed
  3. Click Columns > Check Company checkbox
  4. Check Company Column is displayed between Lastname and Email column
  5. Check if Company Column is sortable
  6. Click Filters
  7. Check if there is Company filter
  8. Type company name
  9. Click Apply Filter or press enter
  10. Result should display only the filtered values

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

… grid - Added MFTF action group to CE > UI admin grid
@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2020

Hi @rsaint20. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

… grid - Added MFTF action group, page and section to CE > Customer module
@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Jul 17, 2020
@ghost ghost assigned dhaecker Jul 17, 2020
… grid - Updated MFTF as per reviewer change request
@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Jul 20, 2020
@ghost ghost moved this from Ready for Testing to Changes Requested in Pull Requests Dashboard Jul 20, 2020
@ghost ghost moved this from Changes Requested to Pending Review in Pull Requests Dashboard Jul 21, 2020
@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Jul 21, 2020
@ghost ghost moved this from Changes Requested to Pending Review in Pull Requests Dashboard Jul 21, 2020
@ghost ghost moved this from Testing in Progress to Ready for Testing in Pull Requests Dashboard Jul 21, 2020
@ghost ghost moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 21, 2020
@ghost ghost moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 21, 2020
@ghost ghost moved this from Extended Testing (optional) to Testing in Progress in Pull Requests Dashboard Jul 22, 2020
@ghost ghost moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 22, 2020
@engcom-Kilo engcom-Kilo self-assigned this Jul 22, 2020
@ghost ghost moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jul 22, 2020
@magento-engcom-team magento-engcom-team merged commit eb98b71 into 2.4-develop Jul 29, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 29, 2020

Hi @rsaint20, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jul 29, 2020
@okorshenko okorshenko deleted the 137_Add_Company_to_Customers_Now_Online_grid branch August 25, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants