Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests with PHPUnit 9 errors #29244

Merged
merged 2 commits into from
Aug 1, 2020
Merged

Fix unit tests with PHPUnit 9 errors #29244

merged 2 commits into from
Aug 1, 2020

Conversation

AntonEvers
Copy link
Contributor

@AntonEvers AntonEvers commented Jul 23, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Most of the failing tests are due to:

  • Depending on setUp logic in dataProviders, while dataProvider code is called before setUp
  • Trying to mock non-existing methods with createPartialMock which is prohibited in PHPUnit 9

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix unit tests with PHPUnit 9 errors #29329: Fix unit tests with PHPUnit 9 errors

@m2-assistant
Copy link

m2-assistant bot commented Jul 23, 2020

Hi @AntonEvers. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jul 23, 2020
@AntonEvers
repair \Magento\Captcha\Test\Unit\Model\Customer\Plugin\AjaxLoginTest
86000ce 
Data providers are executed before setUp.
In previous phpunit versions $this->formIds[0] would just convert to
null, explaining why the logAttempt method was never called.
Fixing this issue leads to different expectations of the test result in
testAroundExecuteCaptchaIsNotRequired. I have adjusted the necessary.

No need to test if this method returns nothing if the return type is
already void

Fix quote unit tests by explicitely declaring methods that are vital
to quote operations. I think it is better to declare these methods
explicitely than to depend on DataObject methods

Update extensionattribute mock

repair partial mock with non-existing method mocking

Revert "Fix quote unit tests by explicitely declaring methods that are vital"

This reverts commit e29506ce3b353d55cbe64d064e863c4969c3d6cd.

fix mock object with non existing method mocks

replace partial mocks with non-existing method mocking
@AntonEvers
Copy link
Contributor Author

@magento run all tests

@AntonEvers
Copy link
Contributor Author

@ihor-sviziev can I ask for your review on this? Starting from today I saw a lot of failing tests.

@ihor-sviziev ihor-sviziev added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix labels Jul 23, 2020
ihor-sviziev
ihor-sviziev previously approved these changes Jul 23, 2020
View reviewed changes
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jul 23, 2020
@ghost ghost assigned ihor-sviziev Jul 23, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7874 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jul 24, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 24, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 24, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jul 27, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7874 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 28, 2020
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 28, 2020
lbajsarowicz
lbajsarowicz approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Thanks!

@ghost ghost moved this from Extended Testing (optional) to Ready for Testing in Pull Requests Dashboard Jul 28, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7874 has been created to process this Pull Request

@ihor-sviziev ihor-sviziev moved this from Ready for Testing to Extended Testing (optional) in Pull Requests Dashboard Jul 28, 2020
@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 30, 2020
Closed
4 tasks
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jul 30, 2020
@slavvka slavvka added the Priority: P3 May be fixed according to the position in the backlog. label Jul 30, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 1, 2020
@slavvka
ENGCOM-7874: Fix unit tests with PHPUnit 9 errors #29244
407f464
@magento-engcom-team magento-engcom-team merged commit 8bdb197 into magento:2.4-develop Aug 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2020

Hi @AntonEvers, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Captcha Component: Developer Component: Persistent Component: Pricing Component: Quote Component: Sales Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix unit tests with PHPUnit 9 errors
7 participants
@AntonEvers @magento-engcom-team @engcom-Alfa @lbajsarowicz @ihor-sviziev @slavvka @engcom-Charlie