Issue 25595 - multiple address virtual product error at checkout fixe…

[ralbin]

When you checkout with multiple addresses, and remove all the products that require shipping and you are only left with virtual products, no error is presented. This sets a default message to it is more helpful.

Description (*)

The class app/code/Magento/Multishipping/Controller/Checkout.php:127 is trying to get an error message that comes from core_config_data but no default message exists, causing the result to be null.
$error = $this->_getCheckout()->getMinimumAmountError();
This sets a default value allowing this render an appropriate message until one is created by the store owner.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Add all type of product into cart, start checkout with multiple address after giving multiple address, except download and virtual type product, remove all four type product from the cart then getting exception  #25595

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ralbin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ralbin]

@magento give me test instance

[magento-engcom-team]

Hi @ralbin. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @ralbin, here is your new Magento instance.
Admin access: https://pr-29269.instances.magento-community.engineering/admin_4ad7
Login: 4d3fbbdc Password: 7e42bc426163
Instance will be terminated in up to 3 hours.

[ralbin]

@magento give me 2.4-develop instance

[magento-engcom-team]

Hi @ralbin. Thank you for your request. I'm working on Magento 2.4-develop instance for you

[magento-engcom-team]

Hi @ralbin, here is your Magento instance.
Admin access: https://i-29269-2-4-develop.instances.magento-community.engineering/admin_6e09
Login: 108e0663 Password: 3ab5558174e9
Instance will be terminated in up to 3 hours.

[ralbin]

@magento run all tests

[ralbin]

@magento run Integration Tests

[ralbin]

@magento run Functional Tests EE

[ralbin]

@magento run all tests

[ralbin]

@magento run Integration Tests

[ralbin]

@magento run Integration Tests

[VladimirZaets]

Hi @ralbin. Thank you for collaboration. Can you please add a translation for the added message?

[ralbin]

@VladimirZaets I added an entry in app/code/Magento/Multishipping/i18n/en_US.csv:95 I hope that is what you expected.

[ralbin]

@magento run all tests

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-8025 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Create 1 Simple and 1 Virtual product;
2. Add both products to cart;
3. Proceed for checkout with multiple addresses;
4. Remove simple product except for virtual;

Before: ✖️ An empty error message appears

After: ✔️ The valid error message is shown

And we are able to translate this phrase:

[engcom-Charlie]

@magento run all tests

[m2-assistant]

Hi @ralbin, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.