Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF tests coverage for Used In links && fix bug with category grid urlFIlterApplie #29392

Merged
merged 5 commits into from
Aug 8, 2020
Merged

MFTF tests coverage for Used In links && fix bug with category grid urlFIlterApplie #29392

merged 5 commits into from
Aug 8, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Aug 5, 2020 •
edited
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes MFTF tests coverage for Used In links adobe-stock-integration#1693: MFTF tests coverage for Used In links
  2. Fixes "Uncaught ReferenceError" appears in dev console if add a new tag and place the mouse cursor over it adobe-stock-integration#1700: "Uncaught ReferenceError" appears in dev console if add a new tag and place the mouse cursor over it

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 5, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Aug 5, 2020
@Nazar65 Nazar65 mentioned this pull request Aug 5, 2020
Closed
@engcom-Golf
Copy link
Contributor

@magento run all tests

@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 5, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 5, 2020

@magento run all tests

sivaschenko
sivaschenko requested changes Aug 5, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @Nazar65 ! Please see my comments

...lleryCatalogUi/Test/Mftf/Test/AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest.xml Outdated Show resolved Hide resolved
...Magento/MediaGalleryCatalogUi/view/adminhtml/layout/media_gallery_catalog_category_index.xml Outdated Show resolved Hide resolved
app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/image/image-edit.js Outdated Show resolved Hide resolved
@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Aug 5, 2020
@ghost ghost assigned sivaschenko Aug 5, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 5, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 5, 2020

@magento run all tests

sivaschenko
sivaschenko requested changes Aug 6, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @Nazar65 ! Please see my comment

app/code/Magento/Ui/view/base/web/templates/grid/filters/elements/ui-select.html Outdated Show resolved Hide resolved
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 6, 2020

@magento run all tests

@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Aug 7, 2020
@ghost ghost removed the Progress: needs update label Aug 7, 2020
@sivaschenko sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 7, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-7972 has been created to process this Pull Request

@chalov-anton chalov-anton self-assigned this Aug 7, 2020
@chalov-anton chalov-anton added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 7, 2020
@chalov-anton
Copy link
Contributor

✔️ QA Passed

No error in dev console when placing mouse cursor over the added tag

Test on Cucumber Studio - https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/3961351

@chalov-anton chalov-anton moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Aug 7, 2020
@chalov-anton chalov-anton moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Aug 7, 2020
@engcom-Kilo engcom-Kilo self-assigned this Aug 7, 2020
@engcom-Kilo
Copy link
Contributor

Failed Functional Tests B2B not related to the changes in this PR

@engcom-Kilo engcom-Kilo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Aug 7, 2020
This was referenced Aug 8, 2020
Closed
Closed
magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2020
@slavvka
ENGCOM-7972: MFTF tests coverage for Used In links && fix bug with ca…
69f8d96 
…tegory grid urlFIlterApplie #29392
@magento-engcom-team magento-engcom-team merged commit 8bae5e6 into magento:2.4-develop Aug 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 8, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@chalov-anton chalov-anton

@engcom-Kilo engcom-Kilo

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryCatalogUi Component: MediaGalleryUi Component: Ui Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
6 participants
@Nazar65 @engcom-Golf @magento-engcom-team @chalov-anton @engcom-Kilo @sivaschenko