Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1684: Login failed error contains HTML tags #29398

Conversation

yolouiese
Copy link
Contributor

Need to verify (*)

  • if error messages no longer contain HTML tags
  • error messages are rendered as HTML

Description (*)

  • added a function to format and render error/success messages as HTML

Fixed Issues (if relevant)

  1. Fixes Login failed error contains HTML tags adobe-stock-integration#1684: Login failed error contains HTML tags

Manual testing scenarios (*)

  1. Go to Content - Media Gallery, click Search Adobe Stock
  2. Save an Unlicensed image Preview
  3. (the image appeared in Media Gallery)
  4. Select the previously saved Unlicensed image
  5. Click "three dots" and select License

Expected result (*)

Proper error message, like "Login failed. Please check if the Secret Key is set correctly and try again."

@m2-assistant
Copy link

m2-assistant bot commented Aug 5, 2020

Hi @yolouiese. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@yolouiese
Copy link
Contributor Author

@magento run all tests

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @yolouiese , can you please cover the messages component with jasmine tests

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Aug 5, 2020
@ghost ghost assigned sivaschenko Aug 5, 2020
@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 5, 2020
@yolouiese yolouiese changed the title #1684: Login failed error contains HTML tags [WIP] #1684: Login failed error contains HTML tags Aug 6, 2020
@yolouiese
Copy link
Contributor Author

@magento run all tests

1 similar comment
@yolouiese
Copy link
Contributor Author

@magento run all tests

@sivaschenko sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 9, 2020
@sivaschenko sivaschenko changed the title [WIP] #1684: Login failed error contains HTML tags #1684: Login failed error contains HTML tags Aug 9, 2020
@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Aug 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-7981 has been created to process this Pull Request

@sivaschenko sivaschenko moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Aug 9, 2020
@sivaschenko
Copy link
Member

@magento run all tests

@sivaschenko sivaschenko moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Aug 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-7981 has been created to process this Pull Request

@sivaschenko
Copy link
Member

@magento run all tests

@sivaschenko sivaschenko moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Aug 14, 2020
@magento-engcom-team magento-engcom-team merged commit c1d2c42 into magento:2.4-develop Aug 15, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 15, 2020

Hi @yolouiese, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryUi Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

Login failed error contains HTML tags
3 participants