Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1709: Modified date is not updated when Editing image Tags the second time #29424

Conversation

jmonteros422
Copy link
Contributor

Description (*)

This PR fixes issue #1709 with the media_gallery_asset's updated_at field not being updated if changes are made on the keyword tags. Unit test is adjusted as well.

Fixed Issues (if relevant)

  1. Fixes Modified date is not updated when Editing image Tags the second time adobe-stock-integration#1709: Modified date is not updated when Editing image Tags the second time

Manual testing scenarios (*)

  1. Go to Content - Media Gallery
  2. Click Search Adobe Stock and Save an image Preview
  3. Wait for two minutes ⌛
  4. Select the previously saved preview image
  5. Click "three dots", select Edit
  6. Remove some of the Tags, add a new Tag... Click Save
  7. Click "three dots", select View Details
  8. Verify that the Modified date has been updated
  9. Wait for two minutes ⌛
  10. Click "three dots", select *Edit
  11. Remove some of the Tags, add a new Tag... Click Save
  12. Click "three dots", select View Details
  13. Verify that the Modified date has been updated

Questions or comments

Need to verify if approach is correct.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…en Editing image tags - Implement update on modified date on media asset if there are changes on keywords.
@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2020

Hi @jmonteros422. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Aug 6, 2020
@jmonteros422
Copy link
Contributor Author

@magento run all tests

sivaschenko
sivaschenko previously approved these changes Aug 7, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Aug 7, 2020
@ghost ghost assigned sivaschenko Aug 7, 2020
@sivaschenko sivaschenko added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 7, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-7973 has been created to process this Pull Request

Copy link
Contributor

@chalov-anton chalov-anton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ QA Failed

The issue is still reproducible. Modified Date is not updated when editing image Tags

@ghost ghost moved this from Ready for Testing to Changes Requested in Pull Requests Dashboard Aug 7, 2020
@ghost ghost assigned chalov-anton Aug 7, 2020
@ghost ghost dismissed sivaschenko’s stale review August 7, 2020 15:53

Pull Request state was updated. Re-review required.

Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jmonteros422!
Thank you for your contribution!

Could you introduce and Integration Test with data saving to check that 'updated_at' column is updated after save.

@ghost ghost assigned swnsma Aug 7, 2020
@jmonteros422
Copy link
Contributor Author

Hi @jmonteros422!
Thank you for your contribution!

Could you introduce and Integration Test with data saving to check that 'updated_at' column is updated after save.

Thank you for the review! Okay!

@jmonteros422
Copy link
Contributor Author

❌ QA Failed

The issue is still reproducible. Modified Date is not updated when editing image Tags

Hi @chalov-anton , Thank you for the QA, Can you retry modifying the tags after a browser refresh. I am only able to reproduce this because of related issue #29400 . Let me know of the results. Thanks!

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reivew @swnsma

The modified date change is going to be covered with the MFTF test as part of #29452

The base modified functionality is already covered with the MFTF test.

@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Aug 10, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-7973 has been created to process this Pull Request

@sivaschenko sivaschenko moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Aug 10, 2020
@sivaschenko sivaschenko moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Aug 10, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 12, 2020
@magento-engcom-team magento-engcom-team merged commit 1e71275 into magento:2.4-develop Aug 12, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 12, 2020

Hi @jmonteros422, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGallery Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

Modified date is not updated when Editing image Tags the second time
5 participants