Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ui-select options placeholders for url-filter-applier #29429

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Fix ui-select options placeholders for url-filter-applier #29429

merged 1 commit into from
Aug 19, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Aug 6, 2020 •
edited
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Used In Link: Asset title is not displayed in the applied filters section. Asset filter does not have the selected value adobe-stock-integration#1694: Used In Link: Asset title is not displayed in the applied filters section. Asset filter does not have the selected value
  2. Fixes Tag isn`t added to second image in Edit mode adobe-stock-integration#1755: Tag isn`t added to second image in Edit mode

Manual testing scenarios (*)

  1. Open the Media Gallery
  2. View details of the image
  3. Click links in Used In section

Expected Result

Corresponding grid is opened with the entities filtered by the image (asset), Asset filter is set and displayed correctly

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Aug 6, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 6, 2020

@magento run all tests

@Nazar65 Nazar65 changed the title Fix ui-select options plaveholders for url-filter-applier Fix ui-select options placeholders for url-filter-applier Aug 6, 2020
@sivaschenko sivaschenko self-assigned this Aug 7, 2020
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Aug 7, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 10, 2020

@magento run all tests

4 similar comments
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 11, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 13, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 14, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 14, 2020

@magento run all tests

sivaschenko
sivaschenko requested changes Aug 14, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @Nazar65 ! Please see my comment, the Asset filter readability can be improved with some refactoring.

Also please cover the View details links with MFTF test verifying the filter labels

app/code/Magento/MediaGalleryUi/Ui/Component/Listing/Filters/Asset.php Outdated
$options = [];
$assetIds = [];

if (!isset($this->filterData[$this->getName()])) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please extract getAssetIds method to reduce the complexity

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Aug 14, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 14, 2020

@magento run all tests

4 similar comments
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 14, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 14, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 14, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 17, 2020

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8019 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sivaschenko sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 17, 2020
@Nazar65
Fix ui-select options placeholders for url-filter-applier && Clean ca…
4ebe9d6 
…ched options for ui-select component after closing slide form
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 17, 2020

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8019 has been created to process this Pull Request

@engcom-Lima engcom-Lima moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Aug 17, 2020
@engcom-Lima
Copy link
Contributor

engcom-Lima commented Aug 17, 2020 •
edited
Loading

✔️ QA Passed
Corresponding grid is opened with the entities filtered by the image (asset), Asset filter is set and displayed correctly
Screenshot_107

Screenshot_108

Screenshot_109

Screenshot_110

Tag added to second image in Edit mode
Peek 2020-08-17 19-55

All cases are covered by manual scenarios

@engcom-Lima engcom-Lima added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 17, 2020
@engcom-Lima engcom-Lima moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Aug 17, 2020
@sivaschenko sivaschenko moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Aug 18, 2020
This was referenced Aug 19, 2020
Closed
Closed
magento-engcom-team pushed a commit that referenced this pull request Aug 19, 2020
@gabrieldagama
ENGCOM-8019: Fix ui-select options placeholders for url-filter-applier …
1d46874 
…#29429
@magento-engcom-team magento-engcom-team merged commit 6a58043 into magento:2.4-develop Aug 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 19, 2020
@sidolov sidolov added this to the 2.4.2 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryCatalogUi Component: MediaGalleryCmsUi Component: MediaGalleryUi Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Project: ASI QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
2.4.2
6 participants
@Nazar65 @magento-engcom-team @engcom-Lima @sivaschenko @sidolov @engcom-Golf