Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suport of reading PNG JPEG Exif metadata #29576

Merged
merged 12 commits into from Aug 19, 2020
Merged

Add suport of reading PNG JPEG Exif metadata #29576

merged 12 commits into from Aug 19, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Aug 17, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Create Exif reader adobe-stock-integration#1449 Create Exif reader

Manual testing scenarios (*)

  1. Upload image to th new media gallery from integration test fixtures exif_image.png or exif-image.jpeg
  2. Discover in image details, metadata from exif segments exifst Title and Description

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Aug 17, 2020
@engcom-Golf
Copy link
Contributor

@magento run all tests

1 similar comment
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 17, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 17, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 17, 2020

@magento run all tests

@sivaschenko sivaschenko added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 17, 2020

@magento run all tests

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Aug 17, 2020
@ghost ghost assigned sivaschenko Aug 17, 2020
@sivaschenko sivaschenko added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Progress: pending review labels Aug 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8020 has been created to process this Pull Request

@Nazar65 Nazar65 mentioned this pull request Aug 17, 2020
Closed
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 17, 2020

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8020 has been created to process this Pull Request

@engcom-Lima engcom-Lima moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Aug 18, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 18, 2020

@magento run all tests

@engcom-Lima
Copy link
Contributor

engcom-Lima commented Aug 18, 2020 •
edited

✔️ QA Passed
Metadata from exif segments exists in image details
Screenshot_115
Screenshot_114

@engcom-Lima engcom-Lima moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Aug 18, 2020
@sivaschenko sivaschenko moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Aug 18, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Aug 19, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Aug 19, 2020
@gabrieldagama
ENGCOM-8020: Add suport of reading PNG JPEG Exif metadata #29576
13e26b2
@magento-engcom-team magento-engcom-team merged commit 9648ffd into magento:2.4-develop Aug 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 19, 2020
@sidolov sidolov added this to the 2.4.2 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryMetadata Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: ASI Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

Create Exif reader
6 participants
@Nazar65 @engcom-Golf @magento-engcom-team @engcom-Lima @sivaschenko @sidolov