Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly revert default mode after mass image deletion #29684

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Correctly revert default mode after mass image deletion #29684

merged 3 commits into from
Aug 25, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Aug 19, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Add selected button still active after image deletion adobe-stock-integration#1769: Add selected button still active after image deletion

Manual testing scenarios (*)

    Go to Content -> Pages
    Add New Page
    Enter "Page Title"
    Expand "Content" section
    Click on the "Show / Hide Editor" -> "Insert Image..."
    Click on the "Delete Images..." button
    Select any image by clicking on it
    Click on the "Delete Selected" button
    Confirm Deleting
    Pay attention - no image is selected
    Click on the "Add Selected"

There is no "Add Selected" button because no image is selected.
Impossible to add an image to page

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@engcom-Golf
Copy link
Contributor

@magento run all tests

@Nazar65 Nazar65 changed the title Correctly revert default view after mass image deletion Correctly revert default mode after mass image deletion Aug 19, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 19, 2020

@magento run all tests

@sivaschenko
Copy link
Member

@Nazar65 please add the check for the button to MFTF test

@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 19, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 20, 2020

@magento run all tests

@rogyar rogyar self-assigned this Aug 20, 2020
@rogyar rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix labels Aug 20, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Aug 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8042 has been created to process this Pull Request

@engcom-Lima engcom-Lima moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Aug 20, 2020
@engcom-Lima engcom-Lima self-assigned this Aug 20, 2020
@engcom-Lima
Copy link
Contributor

✔️ QA Passed
There is no "Add Selected" button because no image is selected.
Peek 2020-08-20 151

@engcom-Lima engcom-Lima moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Aug 20, 2020
@sivaschenko sivaschenko moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Aug 24, 2020
@magento-engcom-team magento-engcom-team merged commit 3b58d96 into magento:2.4-develop Aug 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 25, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: MediaGalleryUi Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

Add selected button still active after image deletion
6 participants