Fix issue with saving filters from url-applier to default view of bookmark

[Nazar65]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Bookmark saves filter from url-applier component to default view in some cases adobe-stock-integration#1789

Manual testing scenarios (*)

1. Open media gallery

2. Open view details from image

3. Click on Used in Categories link

4. Category grid rendered with url-filter applier, and asset filter applied

5. Default view of bookmark saved without filter

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Nazar65]

@magento run all tests

[rogyar]

Hi @sivaschenko. Just want to double-check that we are on the same page.
You've added the "Auto-Tests: Covered" label with no actual coverage introduced in this PR. Does it mean that the change in this PR is supposed to fix the existing failing test?

Thank you.

[Nazar65]

@rogyar failing test is not related to the changes in this pr, also this behaviour already covered by mftf test.

[rogyar]

Hi @Nazar65. Thank you for the clarification.
I mean, if we provide a fix and it's already covered by MFTF tests, usually it means that without the provided fix the tests are supposed to be failing. So the fix eventually fixes the previously failing tests.

If this assumption is correct for the current PR, that's great.

Thanks

[sidolov]

@sivaschenko , @Nazar65 could you please clarify the automation status? I agree with @rogyar , if we are going to fix something- it should be covered with a test. If test is already created then why it's green since we have a bug in functionality?

[Nazar65]

@sidolov this pr fixes bug with js initialization, so covering such functionality with tests is no good idea, because we will introduce one more flaky test, and in this case the ui_bookmark table also needs to be empty.

[sivaschenko]

@sidolov @rogyar the PR contains an improvement to stability of the functionality that is covered by MFTF tests.

In case there is a PR that contains refactoring or implementation change to existing functionality that is covered by MFTF tests, such PR is covered with tests even if it does not change the test results.

[sivaschenko]

@magento run all tests

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-8147 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed

The Default view doesn't contain any bookmarks, it is empty as expected

Manual testing scenario - https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/5115557

[sivaschenko]

Already merged to 2.4.1-develop.

[m2-assistant]

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.