Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "Add Selected" button to be the last in Old Media Gallery #29896

Conversation

joweecaquicla
Copy link

Description (*)

This PR will implement the moving of the "Add Selected" button to be the last in Old Media Gallery.

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Fixes Move "Add Selected" button to be the last in Old Media Gallery adobe-stock-integration#1798

Manual testing scenarios (*)

Preconditions: There must be ann image saved to Media gallery.

  1. Go to Catalog - Categories
  2. Expand Content and click Select from Gallery
  3. Select the previously saved image by clicking on it
  4. The "Add Selected" button should be the last button.

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…the last in Old Media Gallery - moved add selected button
@m2-assistant
Copy link

m2-assistant bot commented Sep 3, 2020

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@joweecaquicla
Copy link
Author

@magento run all tests

@rogyar rogyar self-assigned this Sep 3, 2020
@rogyar
Copy link
Contributor

rogyar commented Sep 3, 2020

Hi @joweecaquicla. To speed up the tests I would suggest for the future running the functional tests only for cases like this one. Running all tests including integration, web-api and others might be redundant.

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 3, 2020
sivaschenko
sivaschenko previously approved these changes Sep 4, 2020
@sivaschenko sivaschenko added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 4, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Sep 4, 2020
@ghost ghost assigned sivaschenko Sep 4, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8138 has been created to process this Pull Request

@engcom-Bravo engcom-Bravo self-assigned this Sep 7, 2020
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 7, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Add selected is the last button
add_posit

Checked the Old Media Gallery and New Media Gallery

This behaviour is covered in several tests in Adobe Stock Scenario base on cucumber studio

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to To Approve in Pull Requests Dashboard Sep 7, 2020
@ghost ghost dismissed sivaschenko’s stale review September 7, 2020 10:16

Pull Request state was updated. Re-review required.

@sivaschenko sivaschenko moved this from To Approve to Merge in Progress in Pull Requests Dashboard Sep 7, 2020
@ghost ghost moved this from Merge in Progress to To Approve in Pull Requests Dashboard Sep 7, 2020
@engcom-Bravo engcom-Bravo moved this from To Approve to Merge in Progress in Pull Requests Dashboard Sep 7, 2020
@ghost ghost moved this from Merge in Progress to To Approve in Pull Requests Dashboard Sep 7, 2020
@engcom-Bravo engcom-Bravo moved this from To Approve to Merge in Progress in Pull Requests Dashboard Sep 7, 2020
@ghost ghost moved this from Merge in Progress to To Approve in Pull Requests Dashboard Sep 7, 2020
@sivaschenko sivaschenko moved this from To Approve to Merge in Progress in Pull Requests Dashboard Sep 7, 2020
@ghost ghost moved this from Merge in Progress to To Approve in Pull Requests Dashboard Sep 7, 2020
@ghost ghost moved this from To Approve to Ready for Testing in Pull Requests Dashboard Sep 7, 2020
@sivaschenko sivaschenko moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 7, 2020
@sivaschenko sivaschenko moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Sep 7, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8138 has been created to process this Pull Request

@sivaschenko sivaschenko changed the title #1798: Move "Add Selected" button to be the last in Old Media Gallery Move "Add Selected" button to be the last in Old Media Gallery Sep 7, 2020
@magento-engcom-team magento-engcom-team merged commit 654b727 into magento:2.4-develop Sep 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 7, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Cms Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: ASI Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

Move "Add Selected" button to be the last in Old Media Gallery
5 participants