-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move "Add Selected" button to be the last in Old Media Gallery #29896
Move "Add Selected" button to be the last in Old Media Gallery #29896
Conversation
…the last in Old Media Gallery - moved add selected button
Hi @joweecaquicla. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
Hi @joweecaquicla. To speed up the tests I would suggest for the future running the functional tests only for cases like this one. Running all tests including integration, web-api and others might be redundant. |
Hi @sivaschenko, thank you for the review. |
Pull Request state was updated. Re-review required.
Hi @sivaschenko, thank you for the review. |
Hi @joweecaquicla, thank you for your contribution! |
Description (*)
This PR will implement the moving of the "Add Selected" button to be the last in Old Media Gallery.
Related Pull Requests
N/A
Fixed Issues (if relevant)
Manual testing scenarios (*)
Preconditions: There must be ann image saved to Media gallery.
Questions or comments
N/A
Contribution checklist (*)