Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed redundant less styles navigation in blank theme #29913

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Removed redundant less styles navigation in blank theme #29913

merged 1 commit into from
Sep 9, 2020

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Sep 4, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Clean up code base navigation in blank theme
Remove some properties re-declare, unneccesary property

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Removed redundant less styles navigation in blank theme #29914: Removed redundant less styles navigation in blank theme

@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 4, 2020
@ihor-sviziev ihor-sviziev self-assigned this Sep 4, 2020
@ihor-sviziev ihor-sviziev moved this from Pending Review to Review in Progress in Pull Requests Dashboard Sep 4, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev added Cleanup Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Sep 4, 2020
@ghost ghost moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Sep 4, 2020
@sidolov sidolov added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Sep 4, 2020
@sidolov
Copy link
Contributor

sidolov commented Sep 4, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Sep 4, 2020
Closed
@mrtuvn mrtuvn force-pushed the remove-redundant-less-blank-theme-navigation branch from e8ae9a5 to 234e767 Compare September 5, 2020 04:51
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@mrtuvn mrtuvn force-pushed the remove-redundant-less-blank-theme-navigation branch from 234e767 to 1b76317 Compare September 5, 2020 07:42
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Sep 5, 2020

ok i have reverted that line back to original as your suggestion

@ihor-sviziev ihor-sviziev moved this from Changes Requested to Review in Progress in Pull Requests Dashboard Sep 5, 2020
@ghost ghost removed the Progress: needs update label Sep 5, 2020
@ghost ghost added the Progress: review label Sep 5, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ghost ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Sep 5, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8144 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Sep 8, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked navigation menu on Blank/Luma themes and on mobile, tablet, desktop view works as before
Result:
image

@engcom-Delta engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 9, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 9, 2020
@engcom-Delta engcom-Delta moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Sep 9, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 9, 2020
@gabrieldagama
ENGCOM-8144: Removed redundant less styles navigation in blank theme #…
af7088f 
…29913
@magento-engcom-team magento-engcom-team merged commit 735d4c6 into magento:2.4-develop Sep 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 9, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 9, 2020
@mrtuvn mrtuvn deleted the remove-redundant-less-blank-theme-navigation branch September 12, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Delta engcom-Delta

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Removed redundant less styles navigation in blank theme
5 participants
@mrtuvn @ihor-sviziev @sidolov @magento-engcom-team @engcom-Delta