Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] add new AdminDeleteTaxRateActionGroup #29929

Merged
merged 6 commits into from
Sep 14, 2020
Merged

[MFTF] add new AdminDeleteTaxRateActionGroup #29929

merged 6 commits into from
Sep 14, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Sep 7, 2020 •
edited by m2-assistant bot
Loading

This PR introducing new AdminDeleteTaxRateActionGroup

Resolved issues:

  1. resolves [Issue] [MFTF] add new AdminDeleteTaxRateActionGroup #29940: [MFTF] add new AdminDeleteTaxRateActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Sep 7, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 7, 2020
@magento-engcom-team magento-engcom-team added Component: Tax Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 7, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 7, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@eduard13 eduard13 self-assigned this Sep 7, 2020
eduard13
eduard13 requested changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Usik2203 could you please check my comments bellow?
Thank you for your contribution.

app/code/Magento/Tax/Test/Mftf/ActionGroup/AdminDeleteTaxRateActionGroup.xml Outdated
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminDeleteTaxRateActionGroup">
<annotations>
<description>Goes to the Admin Tax Rate grid page. Deletes the provided Tax Rate Code.</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion the description doesn't reflect the ActionGroup behavior, additionally we have more actions (filter, selectFirstRow, delete) here than is supposed to.

app/code/Magento/Tax/Test/Mftf/ActionGroup/AdminDeleteTaxRateActionGroup.xml Outdated
Comment on lines 25 to 26
<click selector="{{AdminTaxRateFormSection.deleteRate}}" stepKey="clickDeleteRate"/>
<click selector="{{AdminTaxRateFormSection.ok}}" stepKey="clickOk"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I would rather reuse the section AdminMainActionsSection and AdminConfirmationModalSection elements defined in Backend module than use a separate buttons defined in scope of each module.

app/code/Magento/Tax/Test/Mftf/ActionGroup/AdminDeleteTaxRateActionGroup.xml Outdated
Comment on lines 19 to 22
<click selector="{{AdminDataGridHeaderSection.clearFilters}}" stepKey="clickClearFilters"/>
<fillField selector="{{AdminTaxRateGridSection.filterByTaxIdentifier}}" userInput="{{taxRateCode}}" stepKey="fillNameFilter"/>
<click selector="{{AdminTaxRateGridSection.search}}" stepKey="clickSearch"/>
<waitForPageLoad stepKey="waitForTaxRuleSearch"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would split the grid searching into several ActionGroups, this way we'll have a more granular and reusable action groups:

  • ClearFiltersAdminDataGridActionGroup
  • Filter by RateCode
  • AdminSelectFirstGridRowActionGroup - you may move it to Backend or Ui module, as it's a general ActionGroup and may be reused in any other module
  • Delete the Tax Rate

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Sep 7, 2020
@eduard13 eduard13 added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 7, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 7, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@eduard13
Copy link
Contributor

eduard13 commented Sep 7, 2020

The risk was set to low due to: the suggested changes shouldn't affect other areas.

@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 7, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 8, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 8, 2020
@sidolov
Copy link
Contributor

sidolov commented Sep 8, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Sep 8, 2020
Closed
@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 9, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@Usik2203
Copy link
Contributor Author

@magento run all tests

eduard13
eduard13 approved these changes Sep 13, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests are randomly failing and don't seem to be somehow related with this PR

@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Sep 13, 2020
@ghost ghost removed the Progress: needs update label Sep 13, 2020
@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-8192 has been created to process this Pull Request

@sidolov sidolov moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 14, 2020
@sidolov sidolov moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Sep 14, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 14, 2020
@gabrieldagama
ENGCOM-8192: [MFTF] add new AdminDeleteTaxRateActionGroup #29929
d7152ac
@magento-engcom-team magento-engcom-team merged commit 6658a92 into magento:2.4-develop Sep 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Tax Component: Ui Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] add new AdminDeleteTaxRateActionGroup
4 participants
@Usik2203 @eduard13 @sidolov @magento-engcom-team