The "three dots" context menu is not closed after unsuccessful licensing from Media Gallery

[joweecaquicla]

Description (*)

This PR will introduce the modification that will hide the context menu after unsuccessful licensing from Media Gallery.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes The "three dots" context menu is not closed after unsuccessful licensing from Media Gallery  adobe-stock-integration#1802

Manual testing scenarios (*)

Preconditions

1. Install Magento with Adobe Stock Integration
2. Configured integration in Stores -> Configuration -> Advanced-> System -> Adobe Stock Integration fieldset
3. Old Media Gallery disabled in Stores -> Configuration -> Advanced-> System -> Media Gallery -> Enable Old Media Gallery -> No
4. Provide API Key (Client ID). Do not provide Client Secret.
5. Unlicensed image preview saved to Media Gallery being at the bottom of images

Testing steps

1. Go to Content - Media Gallery, click Search Adobe Stock
2. Select the previously saved Unlicensed image
3. Click "three dots" and select License
4. Do not click anywhere.
5. The context menu is closed after Login failed... message appears

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[joweecaquicla]

@magento run all

[rogyar]

Hi @joweecaquicla. Thank you for the fix. Frankly speaking, the solution looks a little bit "hacky". But at first glance, it looks like the image.js does not know about the collapsible object used in the template.
Anyway, will you have a chance to cover this fix with an MFTF test?

Thank you!

[joweecaquicla]

@magento run all tests

[joweecaquicla]

Hi @rogyar. The MFTF test for this fix will be on a separate PR to Adobe Stock Integration repo as the license action is only available when ASI modules are included.

[sivaschenko]

The MFTF test was created for adobe stock integration in magento/adobe-stock-integration#1826
However it is currently skipped due to magento/adobe-stock-integration#1170 (the skip from the test will be removed once the issue is resolved - need manual testing currently)

[sivaschenko]

@magento run all tests

[sivaschenko]

@magento run Functional Tests EE,Functional Tests B2B

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-8199 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed

The context menu is closed automatically

[m2-assistant]

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.