Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum required php version in bootstrap.php #29993

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Update minimum required php version in bootstrap.php #29993

merged 1 commit into from
Sep 14, 2020

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Sep 11, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Update minimum required php version in bootstrap.php #30004: Update minimum required php version in bootstrap.php

@m2-assistant
Copy link

m2-assistant bot commented Sep 11, 2020

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 11, 2020
@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Sep 11, 2020
@rogyar rogyar self-assigned this Sep 11, 2020
@rogyar
Copy link
Contributor

rogyar commented Sep 11, 2020

Nice catch! 😀

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 11, 2020
@sidolov sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 11, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Sep 11, 2020
@ghost ghost assigned sidolov Sep 11, 2020
@sidolov
Copy link
Contributor

sidolov commented Sep 11, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Sep 11, 2020
Closed
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8184 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8184 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Sep 14, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 14, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Preconditions:

Magento 2.4-develop
Php v.7.2

Manual testing scenario:

  1. Install Magento by using a console

Before: ✖️ we are able to install Magento with PHP v 7.2

After: ✔️ We receive the message in console:

Magento supports PHP 7.3.0 or later. Please read https://devdocs.magento.com/guides/v2.4/install-gde/system-requirements-tech.html

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 14, 2020
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 14, 2020
@engcom-Charlie engcom-Charlie self-assigned this Sep 14, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Sep 14, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 14, 2020
@sidolov
ENGCOM-8184: Update minimum required php version in bootstrap.php #29993
8f8d0de
@magento-engcom-team magento-engcom-team merged commit 4fbf72e into 2.4-develop Sep 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2020

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 14, 2020
@okorshenko okorshenko deleted the ihor-sviziev-patch-1 branch September 17, 2020 16:34
@ihor-sviziev ihor-sviziev mentioned this pull request Oct 10, 2020
Closed
4 tasks
This was referenced Oct 23, 2020
Closed
Closed
Closed
@ihor-sviziev ihor-sviziev mentioned this pull request Nov 2, 2020
Closed
@ihor-sviziev
Copy link
Contributor Author

Wow. Quite big list of issues caused by incorrect minimum php version check...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@sidolov sidolov sidolov approved these changes

Assignees

@rogyar rogyar

@sidolov sidolov

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Update minimum required php version in bootstrap.php
6 participants
@ihor-sviziev @rogyar @sidolov @magento-engcom-team @engcom-Alfa @engcom-Charlie