Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1827: Improve AdminMediaGalleryUploadCategoryImageTest #30042

Merged
merged 2 commits into from
Sep 18, 2020
Merged

#1827: Improve AdminMediaGalleryUploadCategoryImageTest #30042

merged 2 commits into from
Sep 18, 2020

Conversation

joweecaquicla
Copy link

Description (*)

This PR will introduce the improved/modified AdminMediaGalleryUploadCategoryImageTest.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Improve AdminMediaGalleryUploadCategoryImageTest adobe-stock-integration#1827

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

magento/adobe-stock-integration#1827: Improve AdminMediaGalleryUpload…
79ddf9a 
…CategoryImageTest - modified AdminMediaGalleryUploadCategoryImageTest
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2020

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 14, 2020
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

sivaschenko
sivaschenko requested changes Sep 15, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @joweecaquicla ! Please see my comment

app/code/Magento/MediaGalleryUi/Test/Mftf/Test/AdminMediaGalleryUploadCategoryImageTest.xml Outdated
<actionGroup ref="AdminMediaGalleryFolderSelectActionGroup" stepKey="selectCatalogFolder">
<argument name="name" value="catalog"/>
</actionGroup>
<conditionalClick selector="{{AdminMediaGalleryFolderSection.folderArrow(catalog)}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move this conditional click to an action group (i.e. AdminMediaGalleryExpandFolder)

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Sep 15, 2020
@ghost ghost assigned sivaschenko Sep 15, 2020
magento/adobe-stock-integration#1827: Improve AdminMediaGalleryUpload…
751b858 
…CategoryImageTest - applied request changes
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

@joweecaquicla joweecaquicla changed the title [WIP] #1827: Improve AdminMediaGalleryUploadCategoryImageTest #1827: Improve AdminMediaGalleryUploadCategoryImageTest Sep 16, 2020
@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Sep 16, 2020
@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Sep 16, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8218 has been created to process this Pull Request

@sivaschenko sivaschenko moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 16, 2020
@sivaschenko sivaschenko moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Sep 16, 2020
@ghost ghost added the Progress: accept label Sep 16, 2020
@sivaschenko sivaschenko mentioned this pull request Sep 16, 2020
Merged
magento-engcom-team pushed a commit that referenced this pull request Sep 18, 2020
@sidolov
ENGCOM-8218: #1827: Improve AdminMediaGalleryUploadCategoryImageTest #…
7735c43 
…30042
@magento-engcom-team magento-engcom-team merged commit 8a53486 into magento:2.4-develop Sep 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 18, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryUi Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve AdminMediaGalleryUploadCategoryImageTest
3 participants
@joweecaquicla @magento-engcom-team @sivaschenko