Stabilize CMS Page asset links tests #30069

konarshankar07 · 2020-09-16T07:15:11Z

Description (*)

This PR will fix the MFTF test for CMS Page and Media Gallery

Fixed Issues (if relevant)

Fixes Stabilize CMS Page asset links tests #30164

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-09-16T07:15:14Z

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

konarshankar07 · 2020-09-16T07:15:37Z

@magento run all tests

rogyar · 2020-09-16T13:08:29Z

Hi @konarshankar07. To speed up the process, I would recommend running functional tests only on fixing MFTF tests.

rogyar · 2020-09-16T13:08:47Z

@magento run Functional Tests CE

sivaschenko · 2020-09-16T16:28:19Z

@konarshankar07 Thanks for PR! Looks like the fix didn't work on tests. Are you sure the issue is only on MFTF side?

konarshankar07 · 2020-09-17T04:56:33Z

Hello @sivaschenko
Yes, I've tested all the three MFTF test AdminMediaGalleryAssertUsedInLinkPagesGridTest, AdminMediaGalleryCmsUiUsedInPagesFilterTest and AdminMediaGalleryDisabledContentFilterTest. They all have the same issue that Insert Image button is not visible at the time of the execution of <click selector="{{CmsWYSIWYGSection.InsertImageBtn}}" stepKey="clickInsertImage" />. There is another issue with MFTF test after looking at the MFTF report that Image Asset is not deleted from the media gallery after test which is also a reason for failing test which I'll fix in this PR.
Thanks

sivaschenko · 2020-09-17T10:59:24Z

Great, thanks @konarshankar07 !

konarshankar07 · 2020-09-17T13:37:21Z

@magento run Functional Tests CE

konarshankar07 · 2020-09-18T06:03:39Z

@magento run Functional Tests CE

…-1825

sivaschenko · 2020-09-21T12:20:08Z