Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent "Overwrite the existing configuration for ...?" question #30077

Merged
merged 4 commits into from
Sep 24, 2020
Merged

Prevent "Overwrite the existing configuration for ...?" question #30077

merged 4 commits into from
Sep 24, 2020

Conversation

flancer64
Copy link
Contributor

@flancer64 flancer64 commented Sep 16, 2020 •
edited by ihor-sviziev
Loading

Duplication for PR #26818

This question is occurred every time I run:

$ ./bin/magento setup:config:set

after upgrade to 2.3.4

We should ask this question only if new value of configuration option is not equal to the old value,.

Resolved issues:

  1. resolves [Issue] Prevent "Overwrite the existing configuration for db-ssl-verify?" question #29612: Prevent "Overwrite the existing configuration for db-ssl-verify?" question

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 16, 2020

Hi @flancer64. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 16, 2020
@ihor-sviziev ihor-sviziev self-assigned this Sep 16, 2020
@ihor-sviziev ihor-sviziev moved this from Pending Review to Review in Progress in Pull Requests Dashboard Sep 16, 2020
@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 16, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Sep 16, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

ihor-sviziev
ihor-sviziev requested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @flancer64,
Could you fix failing static tests? Functional tests failures looks not related.
It's really strange that we hadn't this failure in prev. PR.

@ghost ghost moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Sep 17, 2020
@flancer64
Update ConfigSetCommand.php
cf1a716 
fix static tests failures:

```
/var/www/html/setup/src/Magento/Setup/Console/Command/ConfigSetCommand.php:76	The method execute() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
```

```
FILE: ...tml/setup/src/Magento/Setup/Console/Command/ConfigSetCommand.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 20 | WARNING | [ ] Class description should contain additional
    |         |     information beyond the name already supplies.
 87 | WARNING | [x] Expected 0 spaces after opening bracket; newline
    |         |     found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
```
@flancer64
Copy link
Contributor Author

@ihor-sviziev , something is done. I hope it will help with static tests.

@ihor-sviziev
Copy link
Contributor

@magento run Static Tests

@ihor-sviziev
Copy link
Contributor

@magento run Static Tests

@ihor-sviziev ihor-sviziev moved this from Changes Requested to Review in Progress in Pull Requests Dashboard Sep 17, 2020
@ihor-sviziev
Copy link
Contributor

@magento run Static Tests

flancer64
flancer64 commented Sep 17, 2020
View reviewed changes
Copy link
Contributor Author

@flancer64 flancer64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution! I didn't see this way (y) ;)

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ghost ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Sep 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8230 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Sep 23, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 23, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Result:
Before:
❌ Overwrite the existing configuration for db-ssl-verify? is shown, when 'driver_options' has no changes in env.php
image

After:
✔️ Overwrite the existing configuration for db-ssl-verify? message is not shown, when 'driver_options' has no changes in env.php
image

✔️ Overwrite the existing configuration for db-ssl-verify? message is shown, when 'driver_options' has new value in env.php
image

@engcom-Delta engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 23, 2020
@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

@engcom-Delta engcom-Delta moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Sep 23, 2020
This was referenced Sep 24, 2020
Closed
Closed
magento-engcom-team pushed a commit that referenced this pull request Sep 24, 2020
@sidolov
ENGCOM-8230: Prevent "Overwrite the existing configuration for ...?" …
9b8d63b 
…question #30077
@magento-engcom-team magento-engcom-team merged commit 11cef3e into magento:2.4-develop Sep 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 24, 2020

Hi @flancer64, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 24, 2020
@flancer64 flancer64 deleted the 2.4-develop-01 branch February 12, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Setup Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Prevent "Overwrite the existing configuration for db-ssl-verify?" question
5 participants
@flancer64 @ihor-sviziev @magento-engcom-team @engcom-Delta @sidolov