Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] add AdminOpenCustomersGridActionGroup #30079

Merged
merged 4 commits into from
Oct 24, 2020
Merged

[MFTF] add AdminOpenCustomersGridActionGroup #30079

merged 4 commits into from
Oct 24, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Sep 16, 2020 •
edited
Loading

This PR add AdminOpenCustomersGridActionGroup and set NavigateToAllCustomerPage action group as deprecated

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/346
https://github.com/magento/partners-magento2b2b/pull/352

@m2-assistant
Copy link

m2-assistant bot commented Sep 16, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 16, 2020
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@rogyar rogyar self-assigned this Sep 17, 2020
rogyar
rogyar requested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Usik2203. Thank you for your contribution. Please, take a look at the failing tests.

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Sep 17, 2020
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 17, 2020
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@Usik2203 Usik2203 changed the title [WIP][MFTF] add AdminOpenCustomersGridActionGroup [MFTF] add AdminOpenCustomersGridActionGroup Sep 23, 2020
@Usik2203
Copy link
Contributor Author

Hi @rogyar
This PR is ready for review.
Thanks

rogyar
rogyar previously approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing media gallery tests are not related to the current changeset

@ghost ghost moved this from Changes Requested to Waiting Related PRs in Pull Requests Dashboard Sep 27, 2020
@ghost ghost removed the Progress: needs update label Sep 27, 2020
@ghost ghost dismissed rogyar’s stale review October 13, 2020 09:39

Pull Request state was updated. Re-review required.

@ghost ghost moved this from Pending Review to Waiting Related PRs in Pull Requests Dashboard Oct 13, 2020
@ghost ghost assigned gabrieldagama Oct 13, 2020
@gabrieldagama
Copy link
Contributor

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8275 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ghost ghost moved this from Waiting Related PRs to Ready for Testing in Pull Requests Dashboard Oct 13, 2020
@gabrieldagama gabrieldagama added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 13, 2020
@ihor-sviziev
Copy link
Contributor

@gabrieldagama thx for fixing PR status.

@engcom-Alfa engcom-Alfa self-assigned this Oct 13, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Extended Testing (optional) in Pull Requests Dashboard Oct 13, 2020
@engcom-Foxtrot engcom-Foxtrot self-assigned this Oct 13, 2020
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Oct 21, 2020
magento-engcom-team pushed a commit that referenced this pull request Oct 24, 2020
@gabrieldagama
ENGCOM-8275: [MFTF] add AdminOpenCustomersGridActionGroup #30079
3e6d077
@magento-engcom-team magento-engcom-team merged commit 2ff303d into magento:2.4-develop Oct 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldagama gabrieldagama gabrieldagama approved these changes

@rogyar rogyar rogyar left review comments

Assignees

@rogyar rogyar

@gabrieldagama gabrieldagama

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: Customer Component: Sales Component: Security Event: MageCONF CD 2020 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Usik2203 @rogyar @gabrieldagama @magento-engcom-team @ihor-sviziev @engcom-Alfa @engcom-Foxtrot @sidolov