Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/partners-magento2b2b#322: Unskip StorefrontProductListWidgetWithSharedCatalogTest #30096

Merged
merged 2 commits into from
Sep 28, 2020
Merged

magento/partners-magento2b2b#322: Unskip StorefrontProductListWidgetWithSharedCatalogTest #30096

merged 2 commits into from
Sep 28, 2020

Conversation

dhaecker
Copy link
Contributor

@dhaecker dhaecker commented Sep 17, 2020 •
edited by sidolov
Loading

Description (*)

Unskipping StorefrontProductListWidgetWithSharedCatalogTest

Related Pull Requests

https://github.com/magento/partners-magento2b2b/pull/337

Fixed Issues (if relevant)

  1. magento/partners-magento2b2b#322: Unskip StorefrontProductListWidgetWithSharedCatalogTest

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@dhaecker
magento/partners-magento2b2b#322: Unskip StorefrontProductListWidgetW…
3045b34 
…ithSharedCatalogTest

 - Unskipping StorefrontProductListWidgetWithSharedCatalogTest
@dhaecker dhaecker self-assigned this Sep 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 17, 2020

Hi @dhaecker. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 17, 2020
@ghost ghost unassigned dhaecker Sep 17, 2020
@danmooney2 danmooney2 self-assigned this Sep 23, 2020
@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Sep 23, 2020
@ghost ghost assigned dhaecker Sep 25, 2020
@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Sep 25, 2020
@danmooney2 danmooney2 moved this from Ready for Testing to Merge in Progress in Pull Requests Dashboard Sep 25, 2020
@ghost ghost moved this from Merge in Progress to Ready for Testing in Pull Requests Dashboard Sep 25, 2020
@ghost ghost moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 28, 2020
@ghost ghost moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 28, 2020
@ghost ghost moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Sep 28, 2020
@ghost ghost added the Progress: accept label Sep 28, 2020
@magento-engcom-team magento-engcom-team merged commit aef112e into 2.4-develop Sep 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 28, 2020

Hi @dhaecker, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 28, 2020
@okorshenko okorshenko deleted the 322_Unskip_StorefrontProductListWidgetWithSharedCatalogTest branch February 9, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmooney2 danmooney2 danmooney2 approved these changes

Assignees

@danmooney2 danmooney2

@dhaecker dhaecker

Labels
Component: Widget Progress: accept project: B2B Release Line: 2.4
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhaecker @danmooney2 @magento-engcom-team