-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove spaces caused patching problem in Product/View #30198
Conversation
It was impossible to apply patch to this file because whitespaces
Hi @ilnytskyi. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run Static Tests |
I believe issue with patching goes from the IDE that you’re using or the git where you’re storing the patch. Anyways I’m ok with applying this small cleanup |
Hi @ihor-sviziev, thank you for the review. |
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests EE |
@magento run Functional Tests EE |
@magento create issue |
✔️ QA Passed Small cleanup
Actual Result: ✔️ Patch successfully applied |
Hi @ilnytskyi, thank you for your contribution! |
It was impossible to apply patch to this file because whitespaces
Description (*)
Code clean up
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: