Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove spaces caused patching problem in Product/View #30198

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

ilnytskyi
Copy link
Contributor

@ilnytskyi ilnytskyi commented Sep 26, 2020

It was impossible to apply patch to this file because whitespaces

Description (*)

Code clean up

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Create a patch for relative lines in PHPstorm
  2. Apply patch
  3. Patch is applied

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] remove spaces caused patching problem in Product/View #30601: remove spaces caused patching problem in Product/View

It was impossible to apply patch to this file because whitespaces
@m2-assistant
Copy link

m2-assistant bot commented Sep 26, 2020

Hi @ilnytskyi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ilnytskyi
Copy link
Contributor Author

@magento run Static Tests

@ihor-sviziev
Copy link
Contributor

I believe issue with patching goes from the IDE that you’re using or the git where you’re storing the patch. Anyways I’m ok with applying this small cleanup

@ihor-sviziev ihor-sviziev self-assigned this Sep 26, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Sep 26, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: pending review Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Cleanup and removed Progress: ready for testing labels Sep 26, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8273 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@sidolov sidolov added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Sep 28, 2020
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Alfa engcom-Alfa self-assigned this Oct 22, 2020
@engcom-Alfa
Copy link
Contributor

@magento create issue

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Oct 22, 2020
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Oct 22, 2020

✔️ QA Passed

Small cleanup

  1. Create a patch for relative lines in PHPstorm
  2. Apply patch

Actual Result: ✔️ Patch successfully applied

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 22, 2020
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Oct 22, 2020
@engcom-Alfa engcom-Alfa moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Oct 22, 2020
@magento-engcom-team magento-engcom-team merged commit f948084 into magento:2.4-develop Oct 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2020

Hi @ilnytskyi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Catalog Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

[Issue] remove spaces caused patching problem in Product/View
5 participants