Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue: Add to Bag within "Click for price" popup not working. #30357

Open
wants to merge 10 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fixed issue: Add to Bag within "Click for price" popup not working. #30357

wants to merge 10 commits into from

Conversation

sanganinamrata
Copy link
Member

@sanganinamrata sanganinamrata commented Oct 7, 2020 •
edited

Description (*)

Fixed Add to cart functionality within *Click for price* popup on any product listings.

Fixed Issues (if relevant)

  1. Fixes Add to Cart button within "Click for price" popup not working. #30356

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 7, 2020

Hi @sanganinamrata. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Oct 7, 2020
@rogyar rogyar self-assigned this Oct 7, 2020
@rogyar
Copy link
Contributor

rogyar commented Oct 7, 2020

@magento run Static Tests

rogyar
rogyar reviewed Oct 7, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sanganinamrata. Thank you for your contribution. Could I ask you to cover your changes with an MFTF test, please?
The test will go through the "Steps to reproduce" described in the original issue and assert that we meet the expected behavior.

Thank you!

@ghost ghost removed the Progress: needs update label Oct 7, 2020
@rogyar rogyar added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Oct 7, 2020
@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Oct 7, 2020
@sidolov sidolov moved this from Pending Review to Review in Progress in Pull Requests Dashboard Oct 7, 2020
@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Oct 15, 2020
@sanganinamrata
Copy link
Member Author

@rogyar Sorry for the late reply, Actually I haven't written the MFTF test till now. But I've identified this issue on Magento 2.3 and 2.4 both and tested it with the above solution.

gabrieldagama
gabrieldagama suggested changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sanganinamrata, thanks for your contribution.

I'm moving this PR to change requested column since it requires test coverage.

@engcom-Foxtrot @engcom-Hotel @engcom-Charlie can you help with test coverage on this?

@ghost ghost moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Oct 20, 2020
@ghost ghost assigned gabrieldagama Oct 20, 2020
@engcom-Charlie engcom-Charlie self-assigned this Oct 20, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@sidolov sidolov removed the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 12, 2020
@m2-community-project m2-community-project bot added this to Changes Requested in Pull Requests Dashboard Nov 12, 2020
@m2-community-project m2-community-project bot removed this from Review in Progress in High Priority Pull Requests Dashboard Nov 12, 2020
@engcom-Charlie engcom-Charlie moved this from Changes Requested to Pending Review in Pull Requests Dashboard Nov 13, 2020
@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 2, 2024
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 10, 2024
@engcom-Delta engcom-Delta self-assigned this Apr 10, 2024
@m2-community-project m2-community-project bot moved this from Testing in Progress to Ready for Testing in Pull Requests Dashboard Apr 10, 2024
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 10, 2024
@engcom-Delta
Copy link
Contributor

@sanganinamrata Please resolve with the conflicts to move ahead with this PR

engcom-Delta
engcom-Delta requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@engcom-Delta engcom-Delta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts on the PR

@m2-community-project m2-community-project bot moved this from Testing in Progress to Changes Requested in Pull Requests Dashboard Apr 10, 2024
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Alfa engcom-Alfa engcom-Alfa requested changes

@engcom-Delta engcom-Delta engcom-Delta requested changes

@koushikch7 koushikch7 koushikch7 approved these changes

@gabrieldagama gabrieldagama Awaiting requested review from gabrieldagama

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@rogyar rogyar

@gabrieldagama gabrieldagama

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Catalog Component: Msrp Component: Wishlist Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Progress: needs update Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Changes Requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add to Cart button within "Click for price" popup not working.
9 participants
@sanganinamrata @rogyar @engcom-Charlie @magento-engcom-team @engcom-Alfa @engcom-Delta @gabrieldagama @koushikch7 @sidolov