Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added correct block class for frontend viewModel reference example. #30358

Merged

Conversation

sanganinamrata
Copy link
Member

@sanganinamrata sanganinamrata commented Oct 7, 2020

Description (*)

Added correct block class for frontend viewModel reference example for class

\Magento\Framework\View\Element\Template

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Added correct block class for frontend viewModel reference example. #30450: Added correct block class for frontend viewModel reference example.

@m2-assistant
Copy link

m2-assistant bot commented Oct 7, 2020

Hi @sanganinamrata. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@@ -19,7 +19,7 @@
* custom view models in block arguments in layout handle file.
*
* Example:
* <block name="my.block" class="Magento\Backend\Block\Template" template="My_Module::template.phtml" >
* <block name="my.block" class="Magento\Framework\View\Element\Template" template="My_Module::template.phtml" >
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are talking about the storefront area here, it makes sense to adjust this example. Thanks.

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 7, 2020
@ghost ghost assigned rogyar Oct 7, 2020
@rogyar rogyar added the Cleanup label Oct 7, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Oct 7, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8315 has been created to process this Pull Request

@sanganinamrata
Copy link
Member Author

@rogyar Will you please add hacktoberfest-accepted label to this PR?

@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 7, 2020
@sanganinamrata
Copy link
Member Author

@sidolov Will you please add hacktoberfest-accepted label to this PR?

@engcom-Alfa engcom-Alfa self-assigned this Oct 12, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Oct 12, 2020
@engcom-Alfa
Copy link
Contributor

@magento create issue

@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Oct 12, 2020
@engcom-Foxtrot engcom-Foxtrot self-assigned this Oct 12, 2020
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Oct 12, 2020
@magento-engcom-team magento-engcom-team merged commit 5f7969d into magento:2.4-develop Oct 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 13, 2020

Hi @sanganinamrata, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Oct 13, 2020
@sanganinamrata sanganinamrata deleted the hacktoberfest_pr_2 branch October 19, 2020 08:52
@sanganinamrata
Copy link
Member Author

@rogyar, Will you please add hacktoberfest-accepted label to this PR? This event is about to finish. Without this label to my PR, I'll be eliminated from that challenge. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: View Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

[Issue] Added correct block class for frontend viewModel reference example.
6 participants