Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/partners-magento2b2b#325: Automate Currency availability test for Company Credit #30368

Merged
merged 7 commits into from
Nov 7, 2020
Merged

magento/partners-magento2b2b#325: Automate Currency availability test for Company Credit #30368

merged 7 commits into from
Nov 7, 2020

Conversation

sagar1dahiwala
Copy link
Contributor

@sagar1dahiwala sagar1dahiwala commented Oct 7, 2020 •
edited by danmooney2
Loading

Description (*)

  • Added data fixture and its rollback for base currency of second website
  • This is required to Automate MC-27116

Related Pull Requests

https://github.com/magento/partners-magento2b2b/pull/420

Fixed Issues (if relevant)

  1. Fixes magento/partners-magento2b2b#325

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@sagar1dahiwala
magento/partners-magento2b2b#325: Automate Currency availability test…
d0b9f8e 
… for Company Credit

- Added data fixture for base currecy of second website
@m2-assistant
Copy link

m2-assistant bot commented Oct 7, 2020

Hi @sagar1dahiwala. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Oct 7, 2020
@rogyar rogyar self-assigned this Oct 8, 2020
@rogyar
Copy link
Contributor

rogyar commented Oct 8, 2020

Hi @sagar1dahiwala. Good job. Could you double-check, please, that the rates added via the fixture are being removed after the rollback? Thanks.

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 8, 2020
@rogyar
Copy link
Contributor

rogyar commented Oct 8, 2020

@magento run Integration Tests

@sagar1dahiwala
Copy link
Contributor Author

Hi, @rogyar Thanks for pointing out. Seems like it's not being rollback. Let me update it.

@sagar1dahiwala
magento/partners-magento2b2b#325: Automate Currency availability test…
646fcd4 
… for Company Credit

- Removed additional rates from the data fixture.
@sagar1dahiwala
Copy link
Contributor Author

Hi, @rogyar After closely look I think that rates are additional for that fixture at this point so I removed it from the fixture it self. Instead of removing it from the rollback. Let me know if you find something. Thanks.

@sagar1dahiwala
Copy link
Contributor Author

@magento run Integration Tests

rogyar
rogyar previously approved these changes Oct 12, 2020
View reviewed changes
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Oct 12, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8327 has been created to process this Pull Request

@ghost ghost moved this from Ready for Testing to Changes Requested in Pull Requests Dashboard Oct 13, 2020
@ghost ghost dismissed rogyar’s stale review October 13, 2020 17:41

Pull Request state was updated. Re-review required.

danmooney2
danmooney2 previously approved these changes Oct 13, 2020
View reviewed changes
@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Oct 13, 2020
@ghost ghost assigned danmooney2 Oct 13, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8327 has been created to process this Pull Request

@ghost ghost moved this from Ready for Testing to Changes Requested in Pull Requests Dashboard Oct 20, 2020
@ghost ghost dismissed stale reviews from rogyar and danmooney2 October 20, 2020 17:37

Pull Request state was updated. Re-review required.

@danmooney2
Copy link
Member

@magento run Static Tests, Integration Tests

@m2-community-project m2-community-project bot moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Nov 5, 2020
@danmooney2
Copy link
Member

Thanks just waiting on the B2B PR

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8327 has been created to process this Pull Request

@joanhe joanhe moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Nov 7, 2020
@joanhe joanhe moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Nov 7, 2020
@magento-engcom-team magento-engcom-team merged commit d4600b9 into 2.4-develop Nov 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 7, 2020

Hi @sagar1dahiwala, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@danmooney2 danmooney2 deleted the 325_currency_availability_for_company_credit branch November 9, 2020 14:49
@sidolov sidolov moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@joanhe joanhe joanhe approved these changes

@danmooney2 danmooney2 danmooney2 left review comments

@rganin rganin Awaiting requested review from rganin

@dhaecker dhaecker Awaiting requested review from dhaecker

Assignees

@rogyar rogyar

@joanhe joanhe

@danmooney2 danmooney2

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: accept project: B2B Release Line: 2.4
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sagar1dahiwala @rogyar @magento-engcom-team @danmooney2 @joanhe