Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectify checkout_index_index.xml layout file cross modules. #30711

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

pratiksangani
Copy link
Contributor

@pratiksangani pratiksangani commented Oct 29, 2020

Description (*)

Removed duplicate layout XML code from checkout_index_index.xml of other modules.

Related Pull Requests

#30538

Fixed Issues (if relevant)

  1. This is code improvement.

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Rectify checkout_index_index.xml layout file cross modules. #30713: Rectify checkout_index_index.xml layout file cross modules.

@m2-assistant
Copy link

m2-assistant bot commented Oct 29, 2020

Hi @pratiksangani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@pratiksangani
Copy link
Contributor Author

@magento create issue

@pratiksangani
Copy link
Contributor Author

@magento run all tests

@pratiksangani
Copy link
Contributor Author

@ihor-sviziev Will you please proceed this PR?

@ihor-sviziev ihor-sviziev added Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Oct 30, 2020
@ihor-sviziev ihor-sviziev self-assigned this Oct 30, 2020
@ghost ghost moved this from Pending Review to Review in Progress in Pull Requests Dashboard Oct 30, 2020
@ghost ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Oct 30, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8413 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@pratiksangani thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE

@sidolov sidolov added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Nov 4, 2020
@m2-community-project m2-community-project bot added Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. and removed Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Nov 4, 2020
@engcom-Delta engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Payment Component: SalesRule Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: ready for testing Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Pull Requests Dashboard
  
Ready for Testing
Development

Successfully merging this pull request may close these issues.

[Issue] Rectify checkout_index_index.xml layout file cross modules.
5 participants