Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem to index catalog with some ID and search catalog #30733

Closed
wants to merge 1 commit into from

Conversation

andreustimm
Copy link

Description (*)

The problem happens when to run the indexer and exist catalog inventory for website_id zero.

Related Pull Requests

Fixed problem to index catalog with some ID and search catalog

Fixed Issues (if relevant)

#30461

Manual testing scenarios (*)

  1. In some scenarios when to run php7.4 bin/magento index:reindex and there is catalog inventory duplicate with the website_id zero, not index and not search catalog products.

Contribution checklist (*)

  • [*] Pull request has a meaningful description of its purpose
  • [*] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 30, 2020

Hi @andreustimm. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@viktorpetryk
Copy link
Contributor

@andreustimm Could you take a look, is this PR really relates to the #30461 issue?

@ghost ghost added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Nov 2, 2020
@andreustimm
Copy link
Author

Hi @victorpetryk look at
http://miromi2-homologacao.onbi.com.br/catalogsearch/result/?q=gym for example.

The same error, resolve to edit these two files, the method addItem() :

  • ./vendor/magento/framework/Data/Collection.php 
    
  • ./vendor/magento/framework/Data/AbstractSearchResult.php
    

@viktorpetryk
Copy link
Contributor

@andreustimm Thank you for clarifying. But, as you can see at this comment, the issue is already fixed by the Magento team and internal PR is waiting for delivery.

@gabrieldagama
Copy link
Contributor

Hi @andreustimm, thanks for your contribution! As described by @victorpetryk I will be closing this PR in favor of the internal fix that is waiting for delivery.

Obrigado!

@m2-assistant
Copy link

m2-assistant bot commented Nov 3, 2020

Hi @andreustimm, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost removed the Progress: pending review label Nov 3, 2020
@ghost ghost removed this from Pending Review in High Priority Pull Requests Dashboard Nov 3, 2020
@andreustimm
Copy link
Author

There is a date for this release? Because I have a store for launching this month.

@gabrieldagama
Copy link
Contributor

There is a date for this release? Because I have a store for launching this month.

The PRs that are merged here and internally are delivered on the 2.4-develop branch and they should be available on the next patch release (unless it is a BIC change). You can find more information on upcoming releases here: https://devdocs.magento.com/release/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Data Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants