Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Provide AdminClickCreateNewCustomerForOrderActionGroup and AdminClickCreateNewOrderOnOrderGridPageActionGroup #30811

Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from
Open

[MFTF] Provide AdminClickCreateNewCustomerForOrderActionGroup and AdminClickCreateNewOrderOnOrderGridPageActionGroup #30811

wants to merge 6 commits into from

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Nov 5, 2020 •
edited by m2-assistant bot

This PR provides AdminClickCreateNewCustomerForOrderActionGroup and AdminClickCreateNewOrderOnOrderGridPageActionGroup

Resolved issues:

  1. resolves [Issue] [MFTF] Provide AdminClickCreateNewCustomerForOrderActionGroup and AdminClickCreateNewOrderOnOrderGridPageActionGroup #30827: [MFTF] Provide AdminClickCreateNewCustomerForOrderActionGroup and AdminClickCreateNewOrderOnOrderGridPageActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Nov 5, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Nov 5, 2020
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 5, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Nov 5, 2020

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 6, 2020
@sidolov
Copy link
Contributor

sidolov commented Nov 6, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Nov 6, 2020
Open
@Usik2203
Copy link
Contributor Author

Usik2203 commented Nov 9, 2020

@magento run Functional Tests B2B

@Usik2203
Copy link
Contributor Author

Usik2203 commented Nov 9, 2020

Hi @rogyar
Could I kindly ask you take a look on this one ? ⬆️
Thank you.

@rogyar rogyar self-assigned this Nov 12, 2020
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Nov 12, 2020
rogyar
rogyar requested changes Nov 12, 2020
View reviewed changes
app/code/Magento/Sales/Test/Mftf/Test/AdminSubmitsOrderWithAndWithoutFieldsValidationTest.xml Outdated
<click selector="{{AdminOrdersGridSection.createNewOrder}}" stepKey="clickCreateNewOrder"/>
<click selector="{{AdminOrderFormActionSection.CreateNewCustomer}}" stepKey="clickCreateCustomer"/>
<actionGroup ref="AdminClickCreateNewOrderOnOrderGridPageActionGroup" stepKey="clickCreateNewOrder"/>
<actionGroup ref="AdminClickCreateNewCustomerForOrderActionGroup" stepKey="clickCreateCustomer"/>
<see selector="{{AdminHeaderSection.pageTitle}}" userInput="Create New Order" stepKey="seeNewOrderPageTitle"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I kindly ask you to refactor this assertion throughout the test as well to make this PR even more valuable?

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogyar Done

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Nov 12, 2020
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Pull Requests Dashboard Nov 16, 2020
@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 20, 2020
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in Pull Requests Dashboard Nov 20, 2020
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot moved this from Ready for Testing to Extended Testing (optional) in Pull Requests Dashboard Nov 23, 2020
@Usik2203
Copy link
Contributor Author

@magento run all tests

@engcom-Echo engcom-Echo self-assigned this Dec 21, 2022
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in Pull Requests Dashboard Dec 21, 2022
@engcom-Lima
Copy link
Contributor

✔️ QA Passed

This PR is of MFTF. Hence, it is QA not applicable.

As there is build conflicts hence, moving this PR to extended testing

@engcom-Lima engcom-Lima self-assigned this Dec 21, 2022
@engcom-Lima engcom-Lima moved this from Ready for Testing to Extended Testing (optional) in Pull Requests Dashboard Dec 21, 2022
@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE,Sample Data Tests B2B,Sample Data Tests EE,Sample Data Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE,Integration Tests,Sample Data Tests B2B,Sample Data Tests CE,Sample Data Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

@engcom-Foxtrot engcom-Foxtrot

@engcom-Lima engcom-Lima

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: extended testing Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Extended Testing (optional)
Milestone
No milestone
8 participants
@Usik2203 @sidolov @engcom-Alfa @engcom-Foxtrot @engcom-Lima @engcom-Echo @rogyar @magento-engcom-team