Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default session lifetime from encryption module to security module #30825

Merged
merged 2 commits into from
Nov 15, 2020

Conversation

thomas-kl1
Copy link
Member

@thomas-kl1 thomas-kl1 commented Nov 6, 2020

Move default session lifetime from encryption module to security module

Resolved issues:

  1. resolves [Issue] Move default session lifetime from encryption module to security module #30859: Move default session lifetime from encryption module to security module

@m2-assistant
Copy link

m2-assistant bot commented Nov 6, 2020

Hi @thomas-kl1. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Nov 9, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Award: bug fix labels Nov 9, 2020
@sidolov sidolov added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Nov 9, 2020
@sidolov
Copy link
Contributor

sidolov commented Nov 9, 2020

@magento create issue

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Nov 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8445 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Nov 10, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Go to Admin -> Stores -> Configuration -> Advanced -> Admin -> Security and set
    Admin Session Lifetime (seconds) to 60 sec;

Screenshot from 2020-11-10 14-56-14
2. Save settings and clear cache;
3. Wait 60 sec and click on the Dashboard;

After: ✔️ The user admin has been logged out

Screenshot from 2020-11-10 14-58-32

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Nov 10, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Nov 10, 2020
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Nov 10, 2020
@engcom-Charlie engcom-Charlie self-assigned this Nov 13, 2020
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in Pull Requests Dashboard Nov 13, 2020
@engcom-Charlie engcom-Charlie moved this from Ready for Testing to Extended Testing (optional) in Pull Requests Dashboard Nov 13, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Nov 13, 2020
@magento-engcom-team magento-engcom-team merged commit f7b5467 into magento:2.4-develop Nov 15, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 15, 2020

Hi @thomas-kl1, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: EncryptionKey Component: Security Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

[Issue] Move default session lifetime from encryption module to security module
6 participants