Update sortOrder load for async css plugin

[mrtuvn]

Description (*)

This update made for sure load async css plugin first before JsFooterPlugin load. We use lower order for let magento run AsyncCssPlugin first then run into JsFooterPlugin. After all that is cache plugins will be run
And we need sure AsyncCssPlugin (If it enabled) run before page cache plugin magento run (Fullpage or varnish)

When enabled CSS critical path
Before this PR
Order plugins
JsFooterPlugin < BuiltinPlugin(PageCache) < VarnishPlugin(PageCache) < AsyncCssPlugin

After this PR
Order plugins now will be
AsyncCssPlugin < JsFooterPlugin < BuiltinPlugin(PageCache) < VarnishPlugin(PageCache)

When not enable CSS critical path

JsFooterPlugin < BuiltinPlugin(PageCache) < VarnishPlugin(PageCache)

If not enable (Move js to bottom page)
default magento will run below order
BuiltinPlugin(PageCache) < VarnishPlugin(PageCache)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes [Issue] Update sortOrder load for async css plugin #30882

Manual testing scenarios (*)

1. Setup site magento 2.4 with code base 2.4-develop
2. Cache types all enabled
3. Enable async css
   Stores > Configuration > Advanced > Developer > Css setttings > Use CSS critical path: YES
4. Clear cache page + config

Questions or comments

CC: @HenKun @sidolov @krzksz @brightonmike Feel free give to me any suggest or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Update sortOrder load for async css plugin #30882: Update sortOrder load for async css plugin

[m2-assistant]

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run all tests

[sidolov]

@magento create issue

[ihor-sviziev]

✔ Approved.

Failing tests looks not related to changes form this PR.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8451 has been created to process this Pull Request

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

I checked - changes are still the same, just were rebased on top of recent changes in 2.4-develop branch, so PR still approved from my side.

@magento run Functional Tests B2B

[engcom-Delta]

✔️ QA passed
Manual testing scenario:

• Cache types all enabled
• Enable async css
• Stores > Configuration > Advanced > Developer > Css setttings > Use CSS critical path: YES
• Add logger to each plugin, like:
  $logger->critical('AsyncCssPlugin is called');
• Clear cache page + config
• Refresh page
• Check logs

Before:
❌ Order plugins:

• JsFooterPlugin < BuiltinPlugin(PageCache) < VarnishPlugin(PageCache) < AsyncCssPlugin

After:
✔️ Order plugins:

• AsyncCssPlugin < JsFooterPlugin < BuiltinPlugin(PageCache) < VarnishPlugin(PageCache)

[engcom-Delta]

Note: Automation tests are passed

[m2-assistant]

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.