Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue magento/magento2#26581 #30892

Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix for issue magento/magento2#26581 #30892

wants to merge 5 commits into from

Conversation

ochnygosch
Copy link
Contributor

Description (*)

Adds integration tests for getExistsStoreValueFlag() in \Magento\Catalog\Model\Product for a situation when multiple instances
of the model are loaded.
Saves loaded entity id in \Magento\Catalog\Model\Attribute\ScopeOverriddenValue and discards cached values for different entity id.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes getExistsStoreValueFlag() in catalog product model returns wrong data #26581

Manual testing scenarios (*)

  1. Run integration tests

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 12, 2020

Hi @ochnygosch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Nov 12, 2020
@ochnygosch
Copy link
Contributor Author

@magento run Integration Tests

@ochnygosch
Copy link
Contributor Author

@magento run Integration Tests

@ochnygosch
Copy link
Contributor Author

@magento run all tests

@ochnygosch
Copy link
Contributor Author

@magento run all tests

@ochnygosch ochnygosch marked this pull request as ready for review November 13, 2020 14:32
@ochnygosch
Copy link
Contributor Author

@magento run all tests

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 16, 2020
fredden
fredden reviewed Oct 24, 2023
View reviewed changes
app/code/Magento/Catalog/Model/Attribute/ScopeOverriddenValue.php
if ($this->loadedEntityId !== $entity->getId()) {
$this->attributesValues = [];
$this->loadedEntityId = $entity->getId();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coding standard requires spaces as indentation. Please can you run vendor/bin/phpcbf --standard=Magento2Framework app/code/Magento/Catalog/Model/Attribute/ScopeOverriddenValue.php to fix this up.

@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Oct 24, 2023
@magento-automated-testing
Copy link

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredden fredden fredden left review comments

Assignees

@fredden fredden

Labels
Component: Catalog Priority: P3 May be fixed according to the position in the backlog. Progress: review Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Review in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getExistsStoreValueFlag() in catalog product model returns wrong data
4 participants
@ochnygosch @fredden @sidolov @magento-engcom-team