[MFTF]: Refactoring of AdminCreateInvoiceTest

[AnnaAPak]

Description (*)

The test is refactored according to the best practices followed by MFTF.

Related Pull Requests

this is "reopen" for 30334

Manual testing scenarios (*)

1. Create order via API
2. Go to Admin
3. Open the order and invoice it
4. Make assertions

Resolved issues:

1. resolves [Issue] [MFTF]: Refactoring of AdminCreateInvoiceTest  #31036: [MFTF]: Refactoring of AdminCreateInvoiceTest

[m2-assistant]

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[AnnaAPak]

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

[gabrieldagama]

@magento create issue

[rogyar]

Ideally, we should remove all side effects created in the test. That means that it would be great to remove the GuestCart as well after the test, if possible.

Thanks

[AnnaAPak]

@rogyar, I suggest there is no need/possibility to delete GuestCartafter the test - as we place the order during the test. In addition, there is no operation with type="delete" in the GuestCartMeta.xml - probably because of the same logic.
Please, correct me if I'm mistaken.

Thanks.

[rogyar]

It's more or less what I was expecting. Just wanted to double-check, maybe we already have a routine for removing the quote.

Nevermind then, thank you for checking.

[rogyar]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[engcom-Charlie]

@magento run all tests

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-8581 has been created to process this Pull Request

[m2-assistant]

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.