-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MFTF]: Refactoring of AdminCreateInvoiceTest #31009
[MFTF]: Refactoring of AdminCreateInvoiceTest #31009
Conversation
Please enter the commit message for your changes. Lines starting
Please enter the commit message for your changes. Lines starting
Merge branch '2.4-develop' into ref-AdminCreateInvoiceTest
Hi @AnnaAPak. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B |
@magento create issue |
<after> | ||
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/> | ||
<deleteData createDataKey="createSimpleProductApi" stepKey="deleteSimpleProductApi"/> | ||
<actionGroup ref="AdminLogoutActionGroup" stepKey="adminLogout"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we should remove all side effects created in the test. That means that it would be great to remove the GuestCart
as well after the test, if possible.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogyar, I suggest there is no need/possibility to delete GuestCart
after the test - as we place the order during the test. In addition, there is no operation
with type="delete"
in the GuestCartMeta.xml - probably because of the same logic.
Please, correct me if I'm mistaken.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more or less what I was expecting. Just wanted to double-check, maybe we already have a routine for removing the quote.
Nevermind then, thank you for checking.
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE |
@magento run all tests |
Hi @sidolov, thank you for the review. |
Hi @AnnaAPak, thank you for your contribution! |
Description (*)
The test is refactored according to the best practices followed by MFTF.
Related Pull Requests
this is "reopen" for 30334
Manual testing scenarios (*)
Resolved issues: