Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Refactoring of AdminCreateOrderAddProductCheckboxTest #31016

Merged
merged 5 commits into from
Dec 21, 2020
Merged

[MFTF] Refactoring of AdminCreateOrderAddProductCheckboxTest #31016

merged 5 commits into from
Dec 21, 2020

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Nov 23, 2020 •
edited by m2-assistant bot
Loading

Description (*)

The test is refactored according to the best practices followed by MFTF.

Manual testing scenarios (*)

  1. Check a product to be added to the Order
  2. Check if "Select" checkbox is checked in the Products Grid
  3. Click the "Add selected product(s) to order" button

Resolved issues:

  1. resolves [Issue] [MFTF] Refactoring of AdminCreateOrderAddProductCheckboxTest #31033: [MFTF] Refactoring of AdminCreateOrderAddProductCheckboxTest

@m2-assistant
Copy link

m2-assistant bot commented Nov 23, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Sales Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 23, 2020
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@rogyar rogyar self-assigned this Nov 24, 2020
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Requests Dashboard Nov 24, 2020
rogyar
rogyar requested changes Nov 24, 2020
View reviewed changes
...e/Magento/Sales/Test/Mftf/ActionGroup/AddSimpleProductToOrderAndCheckCheckboxActionGroup.xml
<description>Adds the provided Simple Product to an Order. Checks if checkbox is checked. Fills in the provided Product Qty. Clicks on 'Add Selected Product(s) to Order'.</description>
</annotations>

<seeCheckboxIsChecked selector="{{AdminOrderFormItemsSection.rowCheck('1')}}" stepKey="verifyProductChecked" after="selectProduct"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnnaAPak. Thank you for your work. Please, correct me if I'm wrong, but this action group is supposed to add a product to the order. But I see only the seeCheckboxIsChecked assertion in the action group.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rogyar. Yes, it extends AddSimpleProductToOrderActionGroup - so both product adding and assertion are performed. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, missed the "extend" part. Thanks.

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Nov 24, 2020
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Pull Requests Dashboard Nov 24, 2020
@gabrieldagama
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Nov 24, 2020
Closed
@gabrieldagama gabrieldagama added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 24, 2020
@m2-community-project m2-community-project bot removed this from Review in Progress in Pull Requests Dashboard Nov 24, 2020
@rogyar
Copy link
Contributor

rogyar commented Nov 26, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Nov 27, 2020
rogyar
rogyar approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests are not related to the current changeset

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Nov 27, 2020
@engcom-Alfa engcom-Alfa self-assigned this Nov 27, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Nov 27, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Nov 27, 2020
@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 27, 2020
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Nov 27, 2020
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Nov 30, 2020
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Nov 30, 2020
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Dec 16, 2020
magento-engcom-team pushed a commit that referenced this pull request Dec 21, 2020
@sidolov
ENGCOM-8492: [MFTF] Refactoring of AdminCreateOrderAddProductCheckbox…
6b62ad2 
…Test #31016
@magento-engcom-team magento-engcom-team merged commit 28af659 into magento:2.4-develop Dec 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 21, 2020

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Refactoring of AdminCreateOrderAddProductCheckboxTest
6 participants
@AnnaAPak @gabrieldagama @rogyar @engcom-Alfa @engcom-Foxtrot @magento-engcom-team