Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

free-payemnt-method-virtual-product-order-status #31077

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

free-payemnt-method-virtual-product-order-status #31077

wants to merge 1 commit into from

Conversation

RakeshJesadiya
Copy link
Contributor

@RakeshJesadiya RakeshJesadiya commented Nov 27, 2020

Step To Reproduce

1 Please Set Zero Subtotal checkout new order status to Processing ( https://imgur.com/a/mrJQyTN )
2.create a virtual Product with Price 0
3.then add to cart that product and place an order with a total of 0
4. then check order status in admin orders grid ( https://imgur.com/a/syfqkkX )

Original Issue: #31046

This PR Resolved the issue of Order status and state to complete when User place an order with 0 amount for the Virtual products.

Earlier When Trying to place order for the Virtual amount with 0 value, Order will be closed automatically.

@m2-assistant
Copy link

m2-assistant bot commented Nov 27, 2020

Hi @RakeshJesadiya. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Nov 27, 2020
@sdzhepa sdzhepa linked an issue Dec 3, 2020 that may be closed by this pull request
@sidolov sidolov moved this from Pending Review to On Hold in Pull Requests Dashboard Dec 10, 2020
@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Feb 11, 2021
@m2-community-project m2-community-project bot moved this from On Hold to Pending Review in Pull Requests Dashboard Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Partner: EY partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Release Line: 2.4
Projects
Pull Requests Dashboard
  
Pending Review
Development

Successfully merging this pull request may close these issues.

Issue with Zero Checkout Subtotal Magento2.4
2 participants