Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Refactoring of ProductsQtyReturnAfterOrderCancelTest #31097

Merged
merged 11 commits into from
Dec 22, 2020
Merged

[MFTF] Refactoring of ProductsQtyReturnAfterOrderCancelTest #31097

merged 11 commits into from
Dec 22, 2020

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Nov 30, 2020 •
edited by m2-assistant bot
Loading

Description (*)

A new test has been created according to the best practices followed by MFTF.
The old "ProductsQtyReturnAfterOrderCancelTest" has been deprecated.

Manual testing scenarios (*)

  1. Create a product
  2. Place an order with the products created (qty to order=4)
  3. Create a partial invoice (qty to invoice=1)
  4. Create a shipment
  5. Cancel the order
  6. Check if product qty is correct

Resolved issues:

  1. resolves [Issue] [MFTF] Refactoring of ProductsQtyReturnAfterOrderCancelTest #31132: [MFTF] Refactoring of ProductsQtyReturnAfterOrderCancelTest

@m2-assistant
Copy link

m2-assistant bot commented Nov 30, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@AnnaAPak AnnaAPak changed the title Refactoring of ProductsQtyReturnAfterOrderCancelTest [MFTF] Refactoring of ProductsQtyReturnAfterOrderCancelTest Nov 30, 2020
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Nov 30, 2020
@rogyar rogyar self-assigned this Nov 30, 2020
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Nov 30, 2020
rogyar
rogyar requested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Please, check my suggestions

app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminInvoiceWIthUpdatedProductQtyActionGroup.xml Outdated

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminInvoiceWIthUpdatedProductQtyActionGroup" extends="AdminCreateInvoiceActionGroup">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check the naming

Suggested change
<actionGroup name="AdminInvoiceWIthUpdatedProductQtyActionGroup" extends="AdminCreateInvoiceActionGroup">
<actionGroup name="AdminInvoiceWithUpdatedProductQtyActionGroup" extends="AdminCreateInvoiceActionGroup">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected, thank you.

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Nov 30, 2020
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Pull Requests Dashboard Nov 30, 2020
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Dec 3, 2020
@engcom-Bravo
Copy link
Contributor

Checked the Manual Scenario provided in the PR-s description

  1. Create a product
  2. Place an order with the products created (qty to order=4)
  3. Create a partial invoice (qty to invoice=1)
  4. Create a shipment
  5. Cancel the order
  6. Check if product qty is correct

The Total Canceled amount is correct. 99$ product price * 3qty = 297$
canceled

Moving the PR to Extended Testing column as this is a Refactoring PR

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 3, 2020
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-assigned this Dec 8, 2020
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Dec 8, 2020
@engcom-Hotel engcom-Hotel moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 8, 2020
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Hotel engcom-Hotel moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Dec 9, 2020
@sidolov sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 21, 2020
@m2-community-project m2-community-project bot moved this from Merge in Progress to Ready for Testing in High Priority Pull Requests Dashboard Dec 21, 2020
magento-engcom-team pushed a commit that referenced this pull request Dec 22, 2020
@gabrieldagama
ENGCOM-8506: [MFTF] Refactoring of ProductsQtyReturnAfterOrderCancelT…
7ffd42a 
…est #31097
@magento-engcom-team magento-engcom-team merged commit 99712c0 into magento:2.4-develop Dec 22, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 22, 2020

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov moved this from Ready for Testing to Recently Merged in High Priority Pull Requests Dashboard Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Bravo engcom-Bravo

@engcom-Hotel engcom-Hotel

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: ConfigurableProduct Component: Quote Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Refactoring of ProductsQtyReturnAfterOrderCancelTest
7 participants
@AnnaAPak @magento-engcom-team @sidolov @engcom-Bravo @engcom-Hotel @rogyar @engcom-Charlie