Issues 31197 - Loading wrong order tax info

[srenon]

Description (*)

Magento references the wrong class object when loading tax info for the admin credit memo and invoice page.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Magento loading the wrong Tax info on admin Invoice and Creditmemo page #31197

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @srenon. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[danielrussob]

@magento give me test instance

[magento-deployment-service]

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

[danielrussob]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

[danielrussob]

@magento run all tests

[magento-deployment-service]

Hi @danielrussob, here is your Magento Instance: https://b1c5d318e6e2281f990ebebb29748997.instances.magento-community.engineering
Admin access: https://b1c5d318e6e2281f990ebebb29748997.instances.magento-community.engineering/admin_df47
Login: 8781410d
Password: b8f977118823

[magento-deployment-service]

Hi @danielrussob, here is your Magento Instance: https://b1c5d318e6e2281f990ebebb29748997-2-4-develop.instances.magento-community.engineering
Admin access: https://b1c5d318e6e2281f990ebebb29748997-2-4-develop.instances.magento-community.engineering/admin_067d
Login: 85d2c4f5
Password: 1b36e51e9ccb

[sidolov]

@srenon could you please cover changes with some kind of automated tests? Thanks!

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Set-up tax rule for CA region.
2. Go to Store->Configuration->Sales->Tax->Orders, Invoices, Credit Memos Display Settings and set
   Include Tax In Order Total -> Yes;
   Display Full Tax Summary -> Yes;
3. Create a simple product.
4. Place order with this product chose State/Province -> California.
5. Place one more order and choose any State/Province except for California (to avoid taxes).
6. Open the second order on the admin panel and create an invoice for it.
7. Open the second order again, go to the Invoices tab, and open the invoice.

Before: ✖️ Invoice page broken

After: ✔️ Invoice page loaded successfully

[m2-assistant]

Hi @srenon, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.