[MFTF] Refactoring of AdminUpdateSimpleProductWithRegularPriceInStockEnabledFlatTest #31221

AnnaAPak · 2020-12-09T10:55:55Z

Description (*)

The test is refactored according to the best practices

Manual testing scenarios (*)

Enable flat catalog product
Create a simple product
Update product (main info) and save
Check if all changes are available on the Product Edit page in Admin
Check if all changes are available on the Product Detail page on Storefront
Check if search by the new SKU is successful

Resolved issues:

resolves [Issue] [MFTF] Refactoring of AdminUpdateSimpleProductWithRegularPriceInStockEnabledFlatTest #31234: [MFTF] Refactoring of AdminUpdateSimpleProductWithRegularPriceInStockEnabledFlatTest

…Test

m2-assistant · 2020-12-09T10:55:58Z

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

AnnaAPak · 2020-12-09T10:56:39Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

rogyar

Hi @AnnaAPak. Good job. Please, check my comments below

rogyar · 2020-12-09T12:10:03Z

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminAssertManageStockOnEditPageActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminAssertManageStockOnEditPageActionGroup">


Please, make sure you are following the guidelines for naming. See 11.3.5.1 item of https://devdocs.magento.com/guides/v2.4/coding-standards/technical-guidelines.html#113-functional-testing

rogyar · 2020-12-09T12:10:51Z

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminAssertProductInfoOnEditPageActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminAssertProductInfoOnEditPageActionGroup">


Please, correct the naming by using the "Assert" prefix before specifying the area. Thank you

rogyar · 2020-12-09T12:11:07Z

.../Magento/Catalog/Test/Mftf/ActionGroup/AdminAssertProductIsAssignedToCategoryActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminAssertProductIsAssignedToCategoryActionGroup">


Please, correct the naming by using the "Assert" prefix before specifying the area. Thank you

rogyar · 2020-12-09T12:11:35Z

...Catalog/Test/Mftf/ActionGroup/StorefrontAssertProductStockStatusOnProductPageActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="StorefrontAssertProductStockStatusOnProductPageActionGroup">


Please, correct the naming by using the "Assert" prefix before specifying the area. Thank you

@rogyar I have fixed naming for all Action Groups. Can you please take a look one more time? Thanks.

sidolov · 2020-12-09T18:18:17Z

@magento create issue

AnnaAPak · 2020-12-10T08:41:57Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

engcom-Alfa · 2020-12-11T07:44:15Z

QA not applicable

…arPriceInStockEnabledFlatTest

engcom-Hotel · 2020-12-14T09:13:02Z

@magento run all tests

…rPriceInStockEnabledFlatTest #31221

m2-assistant · 2020-12-22T00:37:09Z

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

AnnaAPak added 3 commits December 9, 2020 12:24

refactored AdminUpdateSimpleProductWithRegularPriceInStockEnabledFlat…

fe6298b

…Test

added deprecation, refactored

e4fde6b

fixed a typo

1dd1046

magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 9, 2020

rogyar self-assigned this Dec 9, 2020

m2-community-project bot added this to Review in Progress in Pull Requests Dashboard Dec 9, 2020

m2-community-project bot added the Progress: review label Dec 9, 2020

rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 9, 2020

rogyar requested changes Dec 9, 2020

View reviewed changes

m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Dec 9, 2020

m2-community-project bot added Progress: needs update and removed Progress: review labels Dec 9, 2020

sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Dec 9, 2020

m2-community-project bot added this to Changes Requested in High Priority Pull Requests Dashboard Dec 9, 2020

m2-community-project bot removed this from Changes Requested in Pull Requests Dashboard Dec 9, 2020

m2-assistant bot mentioned this pull request Dec 9, 2020

[Issue] [MFTF] Refactoring of AdminUpdateSimpleProductWithRegularPriceInStockEnabledFlatTest #31234

Closed

renamed Action Groups

706e63d

m2-community-project bot moved this from Changes Requested to Review in Progress in High Priority Pull Requests Dashboard Dec 10, 2020

m2-community-project bot added Progress: review and removed Progress: needs update labels Dec 10, 2020

rogyar approved these changes Dec 11, 2020

View reviewed changes

m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Dec 11, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Dec 11, 2020

engcom-Alfa self-assigned this Dec 11, 2020

engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Dec 11, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 11, 2020

engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 11, 2020

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Dec 11, 2020

engcom-Hotel self-assigned this Dec 14, 2020

m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Dec 14, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: extended testing labels Dec 14, 2020

Merge branch '2.4-develop' into ref-AdminUpdateSimpleProductWithRegul…

f6db4a7

…arPriceInStockEnabledFlatTest

engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Dec 14, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 14, 2020

engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 14, 2020

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Dec 14, 2020

engcom-Hotel moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Dec 14, 2020

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Dec 14, 2020

magento-engcom-team pushed a commit that referenced this pull request Dec 22, 2020

ENGCOM-8533: [MFTF] Refactoring of AdminUpdateSimpleProductWithRegula…

ed5d72a

…rPriceInStockEnabledFlatTest #31221

magento-engcom-team merged commit 736554e into magento:2.4-develop Dec 22, 2020

sidolov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Dec 23, 2020

magento-engcom-team removed this from Recently Merged in High Priority Pull Requests Dashboard Oct 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MFTF] Refactoring of AdminUpdateSimpleProductWithRegularPriceInStockEnabledFlatTest #31221

[MFTF] Refactoring of AdminUpdateSimpleProductWithRegularPriceInStockEnabledFlatTest #31221

AnnaAPak commented Dec 9, 2020 •

edited by m2-assistant bot

m2-assistant bot commented Dec 9, 2020

AnnaAPak commented Dec 9, 2020

rogyar left a comment

rogyar Dec 9, 2020

rogyar Dec 9, 2020

rogyar Dec 9, 2020

rogyar Dec 9, 2020

AnnaAPak Dec 10, 2020

sidolov commented Dec 9, 2020

AnnaAPak commented Dec 10, 2020

engcom-Alfa commented Dec 11, 2020

engcom-Hotel commented Dec 14, 2020

m2-assistant bot commented Dec 22, 2020

[MFTF] Refactoring of AdminUpdateSimpleProductWithRegularPriceInStockEnabledFlatTest #31221

[MFTF] Refactoring of AdminUpdateSimpleProductWithRegularPriceInStockEnabledFlatTest #31221

Conversation

AnnaAPak commented Dec 9, 2020 • edited by m2-assistant bot

Description (*)

Manual testing scenarios (*)

Resolved issues:

m2-assistant bot commented Dec 9, 2020

AnnaAPak commented Dec 9, 2020

rogyar left a comment

Choose a reason for hiding this comment

rogyar Dec 9, 2020

Choose a reason for hiding this comment

rogyar Dec 9, 2020

Choose a reason for hiding this comment

rogyar Dec 9, 2020

Choose a reason for hiding this comment

rogyar Dec 9, 2020

Choose a reason for hiding this comment

AnnaAPak Dec 10, 2020

Choose a reason for hiding this comment

sidolov commented Dec 9, 2020

AnnaAPak commented Dec 10, 2020

engcom-Alfa commented Dec 11, 2020

engcom-Hotel commented Dec 14, 2020

m2-assistant bot commented Dec 22, 2020

AnnaAPak commented Dec 9, 2020 •

edited by m2-assistant bot