Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Updating with OpenEditProductOnBackendActionGroup #31243

Merged
merged 2 commits into from
Dec 22, 2020
Merged

[MFTF] Updating with OpenEditProductOnBackendActionGroup #31243

merged 2 commits into from
Dec 22, 2020

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Dec 10, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Utilizing AssertAdminProductIsAssignedToCategoryActionGroup instead of filtering Products Grid by SKU and clicking the first row (in order to decrease test execution time)

Resolved issues:

  1. resolves [Issue] [MFTF] Updating with OpenEditProductOnBackendActionGroup #31249: [MFTF] Updating with OpenEditProductOnBackendActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 10, 2020
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Dec 10, 2020
@sidolov
Copy link
Contributor

sidolov commented Dec 10, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 10, 2020
Closed
@rogyar rogyar self-assigned this Dec 11, 2020
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Dec 11, 2020
@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Dec 11, 2020
@rogyar rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Progress: review labels Dec 11, 2020
@m2-community-project m2-community-project bot moved this from Ready for Testing to Review in Progress in High Priority Pull Requests Dashboard Dec 11, 2020
@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Dec 11, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Dec 14, 2020
@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

Note: Functional Tests CE and Functional Tests EE are failed

@engcom-Delta engcom-Delta moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 14, 2020
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-assigned this Dec 14, 2020
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Dec 14, 2020
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests EE

4 similar comments
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Hotel engcom-Hotel moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 15, 2020
@engcom-Hotel engcom-Hotel moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Dec 15, 2020
magento-engcom-team pushed a commit that referenced this pull request Dec 22, 2020
@gabrieldagama
ENGCOM-8535: [MFTF] Updating with OpenEditProductOnBackendActionGroup #…
d46a92b 
…31243
@magento-engcom-team magento-engcom-team merged commit faf77dd into magento:2.4-develop Dec 22, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 22, 2020

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Delta engcom-Delta

@engcom-Hotel engcom-Hotel

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Updating with OpenEditProductOnBackendActionGroup
6 participants
@AnnaAPak @sidolov @magento-engcom-team @engcom-Delta @engcom-Hotel @rogyar