Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed CliIndexerReindexActionGroup action group usage for Catalog module #31320

Merged
merged 4 commits into from
Jan 6, 2021
Merged

Removed CliIndexerReindexActionGroup action group usage for Catalog module #31320

merged 4 commits into from
Jan 6, 2021

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Dec 17, 2020 •
edited by m2-assistant bot
Loading

Description

Remove CliIndexerReindexActionGroup action group usage or change value for it from tests to improve execution time for the Catalog module.

Resolved issues:

  1. resolves [Issue] Removed CliIndexerReindexActionGroup action group usage for Catalog module #31327: Removed CliIndexerReindexActionGroup action group usage for Catalog module

@m2-assistant
Copy link

m2-assistant bot commented Dec 17, 2020

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 17, 2020
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Dec 17, 2020
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@sergiy-v sergiy-v force-pushed the mftf-CliIndexerReindexActionGroup-usage-catalog-p2 branch from acdf7d9 to 3a808ff Compare December 17, 2020 14:32
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@gabrieldagama
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 17, 2020
Closed
@gabrieldagama gabrieldagama added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Dec 17, 2020
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Dec 17, 2020
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE,Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE

@eduard13 eduard13 self-assigned this Dec 18, 2020
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Dec 18, 2020
@eduard13
Copy link
Contributor

@magento run Functional Tests B2B

@eduard13 eduard13 added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 18, 2020
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

Hello @eduard13,
Just FYI, all Functional Tests are green, so please proceed with checking.
Thank you.

eduard13
eduard13 approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Dec 18, 2020
@engcom-Foxtrot engcom-Foxtrot moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 21, 2020
@eduard13
Copy link
Contributor

@magento run Functional Tests EE,Functional Tests B2B

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-8558 has been created to process this Pull Request

@eduard13
Copy link
Contributor

@magento run Functional Tests EE,Functional Tests B2B

1 similar comment
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE,Functional Tests B2B

@sergiy-v
Merge branch '2.4-develop' into mftf-CliIndexerReindexActionGroup-usa…
a40f256 
…ge-catalog-p2

# Conflicts:
#	app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml
@sergiy-v
Copy link
Contributor Author

@magento run all tests

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE,Functional Tests B2B,Static Tests,Integration Tests

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE,Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@sergiy-v
Copy link
Contributor Author

@magento run all tests

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

1 similar comment
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor

@sergiy-v MFTF tests are green, rerunning all to have whole green builds.

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Dec 29, 2020
magento-engcom-team pushed a commit that referenced this pull request Jan 6, 2021
@gabrieldagama
ENGCOM-8558: Removed CliIndexerReindexActionGroup action group usage …
22fc043 
…for Catalog module #31320
@magento-engcom-team magento-engcom-team merged commit c006f92 into magento:2.4-develop Jan 6, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 6, 2021

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Removed CliIndexerReindexActionGroup action group usage for Catalog module
6 participants
@sergiy-v @gabrieldagama @eduard13 @engcom-Delta @magento-engcom-team @engcom-Foxtrot